| Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] Re: [PATCH] test: check if RTC is RTC_UIE_ON capable
- From: Miroslav Lichvar <mlichvar@xxxxxxxxxx>
- Date: Tue, 10 Dec 2019 17:18:56 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575991150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J0A+2ZcmTTrJx98rHcD34AowFxRsmcQ2pufd6PFVR8U=; b=YIfb2cZQWt8hk3r6zQmHtkfFa+qgEJAeOdBtfMw3HuIo5ZEzwcMb3nm8gQrbBiKIaeRuDg j5BqvV1h6SBfU97wiMRY0MVEsG7gYeZXnJmk4quD60cRHJCaZdtORApCLCbOxllqKAC2V9 dBUPmzC2KKn7VWwbjTPi7EvGSgGwXdI=
On Tue, Dec 10, 2019 at 04:11:14PM +0100, Christian Ehrhardt wrote:
> On Tue, Dec 10, 2019 at 4:06 PM Vincent Blut <vincent.debian@xxxxxxx> wrote:
> > >+hwclock -r --test | grep -q '^ioctl.*RTC_UIE_ON.*Invalid argument$' &&
> > test_skip "RTC not RTC_UIE_ON capable"
> >
> > ^^^^^^^^^^^^^^^^
> > Careful here, hwclock is internationalized.
> >
>
> Thanks for the warning, the ioctl and the flag RTC_UIE_ON should be always
> the same.
> The errno might be changing, but we could just drop that from the check
> maybe and be safe?
I'm sorry for changing my mind, but I now think this case should be
handled gracefully in chronyd and not avoided in the test. According
to the man page, the -s option is supposed to work even with no RTC or
broken RTCs. A hang or fatal error with the -s option may break
the user's expectation.
Do you agree?
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.