| Re: [chrony-dev] Patch: avoid infinite select() loop on chronyc |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
On Mon, Dec 04, 2017 at 06:28:35PM +0100, Miroslav Lichvar wrote:
> On Mon, Dec 04, 2017 at 09:19:07AM -0800, Cristian Gafton wrote:
> > On Mon, 4 Dec 2017, Miroslav Lichvar wrote:
> > > I think the fix should be to check the timeout after its calculation.
> > > If it is negative, a new attempt should be made.
> >
> > I still think we need to limit bound the bnmber of attempts. Making the
> > assumption tat the next time around on a new attempt things will be
> > different is too risky. I'd rather have chronyc exit unsuccessfully than
> > keep trying forever the same codepath that already failed once...
>
> I think it could immediatelly return from the function with zero if
> select() failed (and errno is not EINTR?). In normal operation when
> the server is or is not responding, it's not expected to fail.
This is now in git. Thanks for the report!
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.