Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


On Thu, Jul 13, 2017 at 12:18:02PM +1200, Bryan Christianson wrote:
> macOS 10.13 will implement the ntp_adjtime() system call, allowing better
> control over the system clock than is possible with the existing adjtime()
> system call.
> chronyd will support both the older and newer calls, enabling binary code to
> run without recompilation on macOS 10.9 through macOS 10.13
> 
> Early releases of macOS 10.13 have a very buggy adjtime() call. The macOS
> driver tests adjtime() to see if the bug has been fixed. If the bug
> persists then the timex driver is invoked otherwise the netbsd driver.

Looks great!

> +    if (have_bad_adjtime) {
> +      DEBUG_LOG("adjtime() is buggy - use the timex driver");
> +      SYS_Timex_Initialise();

Is it ok if I change DEBUG_LOG to LOG(LOGS_WARN, ...), so users will
see it in the system log?

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/