| Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime() |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] macOS - support for ntp_adjtime()
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Thu, 13 Jul 2017 23:11:46 +1200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a1707; h=Feedback-ID:X-Smtpcorp-Track:Message-Id:To:Date: Subject:From:Reply-To:Sender:List-Unsubscribe; bh=h4g3rrrfi8q0vBNh76IhAtK8GJrrLx1Crk9kq88I3YA=; b=wOIcrcN/AUYK+0dk2HVJ5s9rDd RlJKw+tG8NpdWL2Vk6tycb45Q/pHtgKiB4np0bA5X6biOYijFydMsHprJVruexzTQqid6K2TDShzI bz3uyjKEwrKe1bn4/uaHGKb6/z9YhfTWRunnn+rRWw88VDfdmnVtsCqtOkOKsH2a1gaHr18KNAiNi /NSFllIbsaqZpicEtu4yYaRRTLO2ZLbldk51gbGnk35Hjr5kORHAT0tuKt3IyN7nhpBmZK0gBug2J dlkGkYkUpCrqaCTWJ4YQIMYAvQWB7s68Fsb/9LYUB5rNazRyYh4zPp8912Wu1lRXeoWLwM51Qvoze S3k8xa5g==;
- Feedback-id: 149811m:149811acx33YQ:149811s5SKt4R3ei:SMTPCORP
> On 13/07/2017, at 11:10 PM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Thu, Jul 13, 2017 at 12:18:02PM +1200, Bryan Christianson wrote:
>> macOS 10.13 will implement the ntp_adjtime() system call, allowing better
>> control over the system clock than is possible with the existing adjtime()
>> system call.
>> chronyd will support both the older and newer calls, enabling binary code to
>> run without recompilation on macOS 10.9 through macOS 10.13
>>
>> Early releases of macOS 10.13 have a very buggy adjtime() call. The macOS
>> driver tests adjtime() to see if the bug has been fixed. If the bug
>> persists then the timex driver is invoked otherwise the netbsd driver.
>
> Looks great!
Thanks :)
>
>> + if (have_bad_adjtime) {
>> + DEBUG_LOG("adjtime() is buggy - use the timex driver");
>> + SYS_Timex_Initialise();
>
> Is it ok if I change DEBUG_LOG to LOG(LOGS_WARN, ...), so users will
> see it in the system log?
>
Yes - good idea.
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.