| Re: [chrony-dev] Patches for s390/s390x and ppc64le support |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
On Wed, Mar 23, 2016 at 02:28:21PM -0600, Mark Post wrote:
> >>> On 3/23/2016 at 05:14 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> > Is this needed always or just when the seccomp support is enabled? If
> > only with seccomp, it should be in the FEAT_SCFILTER #ifdef. Also, I'd
> > rather avoid adding any arch-specific code and include the header even
> > on archs where it's not needed. I'm wondering if that isn't a bug in
> > the libc headers.
>
> It's only needed when using syscall filtering. I can't say for sure if including it for all architectures would cause a problem or not. If you could provide me with a diff that shows how it would be done the way you prefer, I'll give it a try here.
I was thinking something like this:
--- a/sys_linux.c
+++ b/sys_linux.c
@@ -50,6 +50,7 @@
#ifdef FEAT_SCFILTER
#include <sys/prctl.h>
#include <seccomp.h>
+#include <termios.h>
#ifdef FEAT_PHC
#include <linux/ptp_clock.h>
#endif
What error message do you get without the header? If it's related to the RTC
support, the line should be moved couple lines down so the header is included
when both FEAT_SCFILTER and FEAT_RTC are defined.
--
Miroslav Lichvar
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.