| Re: [chrony-dev] Patches for s390/s390x and ppc64le support |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
>>> On 3/23/2016 at 05:14 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
> On Wed, Mar 23, 2016 at 01:43:11AM -0600, Mark Post wrote:
-snip-
>> --- chrony-2.3/sys_linux.c 2016-02-16 08:25:38.000000000 -0500
>> +++ chrony-2.3/sys_linux.c 2016-03-18 13:03:27.510166230 -0400
>> @@ -33,6 +33,10 @@
>>
>> #include <sys/utsname.h>
>>
>> +#if defined(__powerpc64__)
>> +# include <termios.h>
>> +#endif
>
> Is this needed always or just when the seccomp support is enabled? If
> only with seccomp, it should be in the FEAT_SCFILTER #ifdef. Also, I'd
> rather avoid adding any arch-specific code and include the header even
> on archs where it's not needed. I'm wondering if that isn't a bug in
> the libc headers.
It's only needed when using syscall filtering. I can't say for sure if including it for all architectures would cause a problem or not. If you could provide me with a diff that shows how it would be done the way you prefer, I'll give it a try here.
Mark Post
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.