| Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2-48-gfe50212 |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2-48-gfe50212
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Wed, 9 Dec 2015 17:11:02 +1300
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a0-2; h=Feedback-ID:X-Smtpcorp-Track:To:Message-Id:Date: From:Subject; bh=poDSxiL6toJuQKARmaqu0vmBS/ZObVNbNdx0FC7UsvM=; b=3gdbTA6ftJ+c v8jJOQLJcZl7NsgZAMGoKsp8OcIJMiukV/hY8AXzqKwGk6hzgO0L8457XclUR28FnWsGOgt4+P2mO I42M/M8okv5akZtTenm6Poky1eBERo7bSNpa41HB65xUEpdKgsoitzcW4HO4wiltTJcdEF5qhfXZP K9AuSwyTyvJwBJT48eaINcdUFhdCxqpYh5Y8Tv4keTRq+tlJ/kdYISewrv3UQCtfsFu+jFMryuQPi a9BE88vykrCnyOoE28/wTF2HXISFxfbnXTJ8oDv5eqDs8Y6O0NWATwl9LnYsgkE1Rrqpppm2mYQWc WNxALKy55KqR1gopBQ2LUw==;
- Feedback-id: 149811m:149811acx33YQ:149811s3ntwoNPjm:SMTPCORP
> On 9/12/2015, at 7:57 AM, Bryan Christianson <bryan@xxxxxxxxxxxxx> wrote:
>
>
>> On 9/12/2015, at 6:08 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>>
>> On Tue, Dec 08, 2015 at 06:04:00PM +0100, git@xxxxxxxxxxxxx wrote:
>>> Summary of changes:
>>> configure | 18 ++++++++----
>>> main.c | 5 +++-
>>> privops.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++-----------
>>> privops.h | 5 ++++
>>> sys_linux.c | 2 +-
>>> sys_macosx.c | 5 +---
>>> sys_netbsd.c | 3 ++
>>> 7 files changed, 99 insertions(+), 29 deletions(-)
>>
>> Bryan, can you please check if it still works for you on Mac OS X?
>
> if (
> #ifdef SOCK_SEQPACKET
> socketpair(AF_UNIX, SOCK_SEQPACKET, 0, sock_pair) &&
> #endif
> socketpair(AF_UNIX, SOCK_DGRAM, 0, sock_pair))
> LOG_FATAL(LOGF_PrivOps, "socketpair() failed : %s", strerror(errno));
>
> SOCK_SEQPACKET is available on OS X. I don't really know the semantics of this type of socket but the above code looks like its leaking 2 descriptors
duh!! Figured it out - sorry about the noise.
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.