| Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2-48-gfe50212 |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [GIT] chrony/chrony.git branch, master, updated. 2.2-48-gfe50212
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Wed, 9 Dec 2015 07:57:37 +1300
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a0-2; h=Feedback-ID:X-Smtpcorp-Track:To:Message-Id:Date: From:Subject; bh=Y4ec/A4UF0V6RZutHskPKFokdy26AC7B9uZvfkTFCMY=; b=b39lAqFND3a8 Dfywpqnci3wvG0QOTAFP5vOGlhc0LdxOqxnrUOi7mfcSqTijoSBKrA9xUuWrajKptq/8YQyyzM+cy tQC5+V6kqFT6m8LLVwFpo1NvISzlJNKS4rPLXAMtKakDi+/OiEWI7BE0LWRpHQkRfTDe85LcHvWwM Vp78olvCLYULwDymMJ9+bv/m9DHoRg3V1Yt6pRlLjV8BuMG2P5M1X96KGHH3QXD821OEIm2y8iWuF R0q+GeSxhzfzoRAmTgUdnefSvO5xITckK3teGfWkfYdw76ufoojYUugLwJG7/H05kCrzSBZcEulQg d7rx0gOOXsOaFA0hiptHKw==;
- Feedback-id: 149811m:149811acx33YQ:149811s3ntwoNPjm:SMTPCORP
> On 9/12/2015, at 6:08 AM, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> On Tue, Dec 08, 2015 at 06:04:00PM +0100, git@xxxxxxxxxxxxx wrote:
>> Summary of changes:
>> configure | 18 ++++++++----
>> main.c | 5 +++-
>> privops.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++-----------
>> privops.h | 5 ++++
>> sys_linux.c | 2 +-
>> sys_macosx.c | 5 +---
>> sys_netbsd.c | 3 ++
>> 7 files changed, 99 insertions(+), 29 deletions(-)
>
> Bryan, can you please check if it still works for you on Mac OS X?
if (
#ifdef SOCK_SEQPACKET
socketpair(AF_UNIX, SOCK_SEQPACKET, 0, sock_pair) &&
#endif
socketpair(AF_UNIX, SOCK_DGRAM, 0, sock_pair))
LOG_FATAL(LOGF_PrivOps, "socketpair() failed : %s", strerror(errno));
SOCK_SEQPACKET is available on OS X. I don't really know the semantics of this type of socket but the above code looks like its leaking 2 descriptors
--
Bryan Christianson
bryan@xxxxxxxxxxxxx
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.