| Re: [chrony-dev] [PATCH] Fix rounding in UTI_DoubleToTimeval() |
[ Thread Index |
Date Index
| More chrony.tuxfamily.org/chrony-dev Archives
]
- To: chrony-dev@xxxxxxxxxxxxxxxxxxxx
- Subject: Re: [chrony-dev] [PATCH] Fix rounding in UTI_DoubleToTimeval()
- From: Bryan Christianson <bryan@xxxxxxxxxxxxx>
- Date: Thu, 23 Jul 2015 23:38:51 +1200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpcorp.com; s=a0-2; h=Feedback-ID:X-Smtpcorp-Track:To:Message-Id:Date: From:Subject; bh=kx7xXiwheEdVDfcsqVu5fAHKOjusNsWXmtJPRTFg3nU=; b=kdBz0HJy7hSz UC/17e+i68uWlKZkzpHV4v88chqFlKGvFB2ORmhE0ExKpD78q4XPE3Lf4p7RFbPyQqu3isy0w8NzE w3R8+mw3RSNDIB3IIP6H92Mi/j8tJi3vlXPQIS2Y+KAPcmJfGi4tQe/JcWs1TqXg+rpmCPWnrdOuu Ty3E9uKD/eVDymlXGG7MGiwi9RvlapsUG8JyjBsA15ClTQO2PC4xWi5k8XJFgHsF/5ZstFMiFdF73 knClTAdWnrVNcbNnds3m8k2hDrTZwY3u/e7kwyAMtP9Da1AfsB/ywkytn41AK1fuIeCnaX1bCDRBW f27jzLDSPT/n6n1xQbaqDA==;
- Feedback-id: 149811m:149811acx33YQ:149811sghliHTmUl:SMTPCORP
> On 23/07/2015, at 11:28 pm, Miroslav Lichvar <mlichvar@xxxxxxxxxx> wrote:
>
> The change looks good, just some comments on the patch and coding style.
>
> On Thu, Jul 23, 2015 at 10:47:27PM +1200, Bryan Christianson wrote:
>> From 2e37782a50a493c39435e221b7eef9c107bd2e86 Mon Sep 17 00:00:00 2001
>> From: Bryan Christianson <bryan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Is this a valid email address? You might want to set it in git with
> this command
>
> $ git config --global user.email xxxxx
Thanks - I've done that
>
> Also, does the git send-email command work for you? It would make it
> easier for us to review the patches if it wasn't an attachment.
I'll see if I can figure it out - should be possible. I'll redo the patch with your suggestions and see how it goes.
Just one query - I get a lot of compiler warnings from assigning long to the time_t fields and other places that have assumed long is 32 bit. For now I'm just ignoring but these conversion warnings are potential issues. It'd be a pretty big patch to fix them all but I think it should be done at some point
>
--
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble? Email listmaster@xxxxxxxxxxxxxxxxxxxx.