Re: [chrony-dev] [PATCH] Fix rounding in UTI_DoubleToTimeval()

[Miroslav Lichvar <mlichvar@xxxxxxxxxx>]

On Thu, Jul 23, 2015 at 11:38:51PM +1200, Bryan Christianson wrote:
> > Also, does the git send-email command work for you? It would make it
> > easier for us to review the patches if it wasn't an attachment.
> 
> I'll see if I can figure it out - should be possible. I'll redo the patch with your suggestions and see how it goes.

Thanks. You'll probably just need to set the sendemail.smtpserver
variable in your git config so send-email knows where is your SMTP
server.

> Just one query - I get a lot of compiler warnings from assigning long to the time_t fields and other places that have assumed long is 32 bit. For now I'm just ignoring but these conversion warnings are potential issues. It'd be a pretty big patch to fix them all but I think it should be done at some point

Yeah, that casting to long should be probably removed and I actually
thought about doing that everywhere in util.c when I saw your patch.

Please feel free to submit a patch for that too.

Does Mac OS X have 32-bit time_t and 64-bit long? Or it's the other
way around?

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.