Re: [chrony-dev] [PATCH] ntp_core.c: Remove useless assignment `prev = inst->local_rx;`

[ Thread Index | Date Index | More chrony.tuxfamily.org/chrony-dev Archives ]


On Thu, Oct 03, 2013 at 02:34:46PM +0200, Paul Menzel wrote:
> The Clang static analyzer scan-build found the following unneeded
> assignment.
> 
>         /usr/share/clang/scan-build/ccc-analyzer -O2 -g  -c sources.c
>         ntp_core.c:1545:3: warning: Value stored to 'prev' is never read
>           prev = inst->local_rx;
>           ^      ~~~~~~~~~~~~~~
>         1 warning generated.

The value is used when compiled with tracing (./configure --enable-trace).

> Indeed `prev` is not read before being assigned the same value again
> some lines below.

The second prev assignemt is to local_tx (not local_rx).

Would the following patch fix the warning?

--- a/ntp_core.c
+++ b/ntp_core.c
@@ -1548,6 +1548,8 @@ NCR_SlewTimes(NCR_Instance inst, struct timeval *when, double dfreq, double doff
 #ifdef TRACEON
   LOG(LOGS_INFO, LOGF_NtpCore, "rx prev=[%s] new=[%s]",
       UTI_TimevalToString(&prev), UTI_TimevalToString(&inst->local_rx));
+#else
+  (void)prev;
 #endif
   prev = inst->local_tx;
   if (inst->local_tx.tv_sec || inst->local_tx.tv_usec)

-- 
Miroslav Lichvar

-- 
To unsubscribe email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "unsubscribe" in the subject.
For help email chrony-dev-request@xxxxxxxxxxxxxxxxxxxx with "help" in the subject.
Trouble?  Email listmaster@xxxxxxxxxxxxxxxxxxxx.


Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/