Re: [vhffs] autotools for #542 - revision 2

[ Thread Index | Date Index | More vhffs.org/vhffs Archives ]


Le lundi 16 avril 2007 à 18:30 +0200, Sébastien Le Ray a écrit :
> Le Wed, 11 Apr 2007 21:45:41 +0200,
> Alexandre Ghisoli <alexandre.ghisoli@xxxxxxx> a écrit :
> 
> > Hello, 
> > 
> > Please, find attached a new version of the patch.
> > Changes :
> > 
> > . Added Config::General perl module cheking
> > 
> > . Now make install will install /etc/vhffs/vhffs.conf only if it
> >   doesnt exist. All other cases will install as vhffs.conf.dist.
> >   This is done with a file renaming, vhffs.conf.in to
> > vhffs.conf.dist.in IMOO, this job should be done by the packaging
> > system (rpm, ebuild, ...) and users should not rely on makefiles to
> > avoid configuation files loss.
> > 
> > . Fixed a nasty bug arround VHFFS_LIBDIR definition in configure.ac
> >   caused by a misusage of ()
> >   Thanks to beuss to point this out
> > 
> > . Fixed a TEMPLATEDIR mismatch between user specified path, and
> >   a option in the config file.
> > 
> > You can download if from : 
> > http://www.ghisoli.ch/run/node/38
> > 
> > Regards
> > 
> > --Alexandre
> 
> 
> Hi again,
> is there a reason for vhffs-tools to be in EXTRA_DIST ? I think we
> should install it...

This is a mistake, look at vhffs-tools/Makefile.am and
vhffs-tools/src/Makefile.am, they provide install methods, and
configure.ac is setup to generate thoses makefiles.

So just add vhffs-tools in SUBDIRS at toplevel Makefile.am.

Regards

--Alexandre




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/