| [vhffs-dev] [PATCH] panel: fix tabulation navigation for ValidationTextBox dijits |
[ Thread Index |
Date Index
| More vhffs.org/vhffs-dev Archives
]
- To: vhffs-dev@xxxxxxxxx
- Subject: [vhffs-dev] [PATCH] panel: fix tabulation navigation for ValidationTextBox dijits
- From: Léo El Amri <leo@xxxxxxxxxxx>
- Date: Sun, 31 May 2020 18:19:12 +0200
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=superlel.me; s=defaultjuly2017; h=Content-Type:MIME-Version:Date:Message-ID:To:Reply-To:Subject:From; bh=DSl9QKBs2946dgkA8eY/Zs2zmtl6UJlNBukiZY8006g=; b=FWqugss4ONqQHHojYusm7qw+f5JIQOGlSyETFvWjQ11whBItNnWTo8+Av1okCzGnTpypOFJDtsP2ZMO4LAhso5E2cFcUj4SqjN4KoChjFbK+yAKdY6dUHjgHqEW25KAm3AlAWus14mr/1QLUTjpl3sPs6KVB4nyx5Kx0cYjd/ofKpAyWVBJgxWnG9LqB0eI7UsL7hdKThPTFVCE/0fErJJqfXuyleIvJ0T1FuanUNQa0lV3Vrs6GvZuJ5LU//EvwweEEq1p5WHCNDsYwFb4JZEP79N6ULUHXl/l+2ip+WyY/TMIJUYU8SxRRajcZWnpkl6VcJbtjfofy1L288lpQxQ==;
Sorry for the last message, here is the patch attached.
From e562fe5c410708419ec125c76bab9d259cddd8b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?L=C3=A9o=20El=20Amri?= <leo@xxxxxxxxxxx>
Date: Sun, 31 May 2020 17:00:22 +0200
Subject: [PATCH] panel: fix tabulation navigation for ValidationTextBox dijits
Prior to this, ValidationTextBox validation icons were focusable through
tabulation navigation.
---
vhffs-panel/js/dijit/form/ComboBox.js | 2 +-
vhffs-panel/js/dijit/form/ValidationTextBox.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vhffs-panel/js/dijit/form/ComboBox.js b/vhffs-panel/js/dijit/form/ComboBox.js
index 5aef1454..27429213 100644
--- a/vhffs-panel/js/dijit/form/ComboBox.js
+++ b/vhffs-panel/js/dijit/form/ComboBox.js
@@ -117,7 +117,7 @@ dojo.declare(
// Defaults to true.
hasDownArrow: true,
- templateString: dojo.cache("dijit.form", "templates/ComboBox.html", "<div class=\"dijit dijitReset dijitInlineTable dijitLeft\"\n\tid=\"widget_${id}\"\n\tdojoAttachPoint=\"comboNode\" waiRole=\"combobox\"\n\t><div class='dijitReset dijitRight dijitButtonNode dijitArrowButton dijitDownArrowButton dijitArrowButtonContainer'\n\t\tdojoAttachPoint=\"downArrowNode\" waiRole=\"presentation\"\n\t\tdojoAttachEvent=\"onmousedown:_onArrowMouseDown\"\n\t\t><input class=\"dijitReset dijitInputField dijitArrowButtonInner\" value=\"▼ \" type=\"text\" tabIndex=\"-1\" readOnly waiRole=\"presentation\"\n\t\t\t${_buttonInputDisabled}\n\t/></div\n\t><div class='dijitReset dijitValidationContainer'\n\t\t><input class=\"dijitReset dijitInputField dijitValidationIcon dijitValidationInner\" value=\"Χ \" type=\"text\" tabIndex=\"-1\" readOnly waiRole=\"presentation\"\n\t/></div\n\t><div class=\"dijitReset dijitInputField dijitInputContainer\"\n\t\t><input class='dijitReset dijitInputInner' ${!nameAttrSetting} type=\"text\" autocomplete=\"off\"\n\t\t\tdojoAttachEvent=\"onkeypress:_onKeyPress,compositionend\"\n\t\t\tdojoAttachPoint=\"textbox,focusNode\" waiRole=\"textbox\" waiState=\"haspopup-true,autocomplete-list\"\n\t/></div\n></div>\n"),
+ templateString: dojo.cache("dijit.form", "templates/ComboBox.html", "<div class=\"dijit dijitReset dijitInlineTable dijitLeft\"\n\tid=\"widget_${id}\"\n\tdojoAttachPoint=\"comboNode\" waiRole=\"combobox\"\n\t><div class='dijitReset dijitRight dijitButtonNode dijitArrowButton dijitDownArrowButton dijitArrowButtonContainer'\n\t\tdojoAttachPoint=\"downArrowNode\" waiRole=\"presentation\"\n\t\tdojoAttachEvent=\"onmousedown:_onArrowMouseDown\"\n\t\t><input class=\"dijitReset dijitInputField dijitArrowButtonInner\" value=\"▼ \" type=\"text\" tabIndex=\"-1\" readOnly waiRole=\"presentation\"\n\t\t\t${_buttonInputDisabled}\n\t/></div\n\t><div class='dijitReset dijitValidationContainer'\n\t\t><input class=\"dijitReset dijitInputField dijitValidationIcon dijitValidationInner\" value=\"Χ \" type=\"text\" disabled=\"disabled\" readOnly waiRole=\"presentation\"\n\t/></div\n\t><div class=\"dijitReset dijitInputField dijitInputContainer\"\n\t\t><input class='dijitReset dijitInputInner' ${!nameAttrSetting} type=\"text\" autocomplete=\"off\"\n\t\t\tdojoAttachEvent=\"onkeypress:_onKeyPress,compositionend\"\n\t\t\tdojoAttachPoint=\"textbox,focusNode\" waiRole=\"textbox\" waiState=\"haspopup-true,autocomplete-list\"\n\t/></div\n></div>\n"),
baseClass: "dijitTextBox dijitComboBox",
diff --git a/vhffs-panel/js/dijit/form/ValidationTextBox.js b/vhffs-panel/js/dijit/form/ValidationTextBox.js
index 8f97bcff..d559da7b 100644
--- a/vhffs-panel/js/dijit/form/ValidationTextBox.js
+++ b/vhffs-panel/js/dijit/form/ValidationTextBox.js
@@ -36,7 +36,7 @@ dojo.declare(
// tags:
// protected
- templateString: dojo.cache("dijit.form", "templates/ValidationTextBox.html", "<div class=\"dijit dijitReset dijitInlineTable dijitLeft\"\n\tid=\"widget_${id}\" waiRole=\"presentation\"\n\t><div class=\"dijitReset dijitValidationContainer\"\n\t\t><input class=\"dijitReset dijitInputField dijitValidationIcon dijitValidationInner\" value=\"Χ \" type=\"text\" tabIndex=\"-1\" readOnly=\"readonly\" waiRole=\"presentation\"\n\t/></div\n\t><div class=\"dijitReset dijitInputField dijitInputContainer\"\n\t\t><input class=\"dijitReset dijitInputInner\" dojoAttachPoint=\"textbox,focusNode\" autocomplete=\"off\"\n\t\t\t${!nameAttrSetting} type=\"${type}\"\n\t/></div\n></div>\n"),
+ templateString: dojo.cache("dijit.form", "templates/ValidationTextBox.html", "<div class=\"dijit dijitReset dijitInlineTable dijitLeft\"\n\tid=\"widget_${id}\" waiRole=\"presentation\"\n\t><div class=\"dijitReset dijitValidationContainer\"\n\t\t><input class=\"dijitReset dijitInputField dijitValidationIcon dijitValidationInner\" value=\"Χ \" type=\"text\" disabled=\"disabled\" readOnly=\"readonly\" waiRole=\"presentation\"\n\t/></div\n\t><div class=\"dijitReset dijitInputField dijitInputContainer\"\n\t\t><input class=\"dijitReset dijitInputInner\" dojoAttachPoint=\"textbox,focusNode\" autocomplete=\"off\"\n\t\t\t${!nameAttrSetting} type=\"${type}\"\n\t/></div\n></div>\n"),
baseClass: "dijitTextBox dijitValidationTextBox",
// required: Boolean
--
2.26.2