[vhffs-dev] [svn] commit: r74 - trunk/vhffs-api/src/Vhffs/Services/Cvs.pm

[vhffs-dev@xxxxxxxxx]

Author: soda
Date: Thu Jul 28 23:39:38 2005
New Revision: 74

Log:
FIX A BIG BIG SECURITY HOLE 


Modified:
    trunk/vhffs-api/src/Vhffs/Services/Cvs.pm

Modified: trunk/vhffs-api/src/Vhffs/Services/Cvs.pm
==============================================================================
--- trunk/vhffs-api/src/Vhffs/Services/Cvs.pm (original)
+++ trunk/vhffs-api/src/Vhffs/Services/Cvs.pm Thu Jul 28 23:39:38 2005
@@ -51,6 +51,7 @@
 sub delete
 {
 	my $self = shift;
+	$self->fetch;
 
     my $query = "DELETE FROM vhffs_cvs WHERE object_id='".$self->{'object_id'}."'";
     my $request = $self->{'db'}->{'DB_WRITE'}->prepare($query);
@@ -185,7 +186,7 @@
     my $result;
     my $tmp;
 
-    if( ( defined $state ) && ( $state < Vhffs::Constants::TO_DELETE ) )
+    if( defined $state )
     {
         $query = "SELECT c.cvsroot, c.object_id FROM  vhffs_cvs c, vhffs_object o WHERE o.state='".$state."' AND c.object_id = o.object_id";
     }