[xmoto-dev] svn 1404 : merged benetnash with trunk

[ Thread Index | Date Index | More lists.tuxfamily.org/xmoto-dev Archives ]


benetnash,

thanks for your changes,
some remarks:

- about this comment
/* unfortunately because of differences betw->setClicked(false);een finishTime
in webhighscores and replays table (one is rounded to 0.01s and other to 0.001s)
and lack of math functions in sqlite we cannot make it with just one smart query
:( */
i don't understand because just after, you have only one query.
can you write which sqlite math function is required so that we can update
easierly once it will exist
for the current existing one : http://sqlite.org/lang_expr.html (min, max,
round)
for information, in webhighscores you have the web highscore (minute on 2
numbers, sec on 2 numbers, hundread on 2 numbers) ; this value is rounded when a
highscore is received by the webserver. in the replay tab, you've the real time
(precision is the one of the float type)

- about the query :
I would prefer you put it into one function for example
UploadAllHighscores
because the GameMenu.cpp must not become bigger.

- about this expression
("Upload all replays on the website of highscores (experimental)")
Why is it experimental ? is there a case in which it doesn't work ?

- about BikePlayer.cpp and BikePlayer.h
i want you revert these changes ; i won't the biker behavior change for the
moment, then, please don't modify it please.

Nicolas



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/