Re: [Sawfish] Activate workspace if 'focus-windows-when-mapped set patch

[fuchur <flohtransporter@xxxxxxxxx>]

Hi,

On Tue, 03 Apr 2012 15:54:40 +0900 (JST)
wrote Teika Kazura <teika@xxxxxxxxxxx>:

>On Tue, 3 Apr 2012 04:04:33 +0200, fuchur wrote:
>>      (when (and (window-really-wants-input-p w)
>> -               (window-visible-p w)
>> +               (or (window-visible-p w)
>> +                   (window-workspaces w))
>>                 (or (let ((focus (input-focus)))  
>
>The logic is correct, but please delete this part.  window-workspaces
>returns nil if it's WS sticky. (It should be documented.) But the
>original goal of this function is to *focus* the mapped window. With
>this hunk, a sticky window won't get the focus, I'm afraid.

Sticky get focus with the patch, i have check this. I don't know why
without my patch window-visible-p is necessary so maybe it gives
windows which not visible and also not appears on a workspace.

Activate workspace will only work if we remove both

(or (window-visible-p w)
(window-workspaces w))

only remove (window-workspaces w)) can't work because if "appears"
windows on a other workspace as select window-visible-p is nil.

Do you sure window-visible-p is only there to check if window
on the current workspace?

-- 
Regards,
Fuchur

GPG Fingerprint: CA3B 8204 5B3E 6D48 6D53  C116 E5BC 70D5 B8D7 B2B0

Attachment: signature.asc
Description: PGP signature