| [Sawfish] A rep-gtk patch to fix undefined symbol |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/sawfish Archives
]
- To: sawfish@xxxxxxxxxxxxxxxxxxx
- Subject: [Sawfish] A rep-gtk patch to fix undefined symbol
- From: Teika Kazura <teika@xxxxxxxxxxx>
- Date: Mon, 27 Jun 2011 10:49:55 +0900 (JST)
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=xQ3akR0jEaVdmVMQZnuvNiWUQqlPRlAW/XaoJKgu3ct7Q36modIlOcDem5R5AwqBUaNsq8XZYH9rRtsPkHUpH19BA2mrJvdUQogms0z0twGGwHG76fU0ukuC65r8nFZGHUwemeuWfWPuczQ2Tq0eXGftEGXO7pJcTiC/1AZdL6s=; h=Date:Message-Id:To:Subject:From:Mime-Version:Content-Type:Content-Transfer-Encoding;
Hi. There's an undefined symbol in rep-gtk.
In rep-gtk.c, "scm_is_pair" is not defined. It appears only once in
sgtk_valid_segment(), but that function is not used at all, so you can
comment it out altogether without immediate trouble.
I've attached the patch to comment out the function, but I don't know
the exact meaning. It's added in commit 8fa2e32c28163, and the
ChangeLog implies that it's borrowed from guile-gtk. Can we delete
it?
With best regards,
Teika (Teika kazura)
commit 79fb2094744d54609647883f1a93b7ba23bab816
Author: Teika kazura <teika@xxxxxxxxxxx>
Date: Thu Jun 2 21:01:51 2011 +0900
Fix of implicit declaration 'scm_is_pair'
'scm_is_pair' is only used in the function 'sgtk_valid_segment' but
it doesn't seem to be used, so it's commented out.
diff --git a/rep-gtk.c b/rep-gtk.c
index 88b9d31..aa7f279 100644
--- a/rep-gtk.c
+++ b/rep-gtk.c
@@ -1122,6 +1122,7 @@ sgtk_type_to_rep (GType t)
return sgtk_uint_to_rep (t);
}
+/*
int
sgtk_valid_segment (repv obj)
{
@@ -1129,6 +1130,7 @@ sgtk_valid_segment (repv obj)
&& sgtk_valid_point (rep_CAR (obj))
&& sgtk_valid_point (rep_CDR (obj));
}
+*/
GdkSegment
sgtk_rep_to_segment (repv obj)