Re: [proaudio] libffado-9999 debug bug

[Gavin Pryke <gavinlee303@xxxxxxxxx>]

On Wednesday 26 September 2012 16:35:27 Sebastian Rose wrote:
> On 20/09/12 17:50, Gavin Pryke wrote:
> > On Sunday 16 September 2012 14:11:56 Sebastian Rose wrote:
> >> Hello,
> >> 
> >> the current libffado-9999.ebuild doesn't work properly. It builts ffado
> >> with DEBUG=True and ENABLE_OPTIMIZATIONS=False regardless if the USE
> >> flag "debug" is set or not. In my case this lead to ffado constantly
> >> producing xruns, so it would be good to change this. Since FFADO uses
> >> scons as build system, I was following these guidelines:
> >> http://devmanual.gentoo.org/eclass-reference/scons-utils.eclass/index.htm
> >> l
> >> To produce the attached ebuild.
> >> Notes:
> >> - "die" calls removed, since escons dies on failure in EAPI 4
> >> - changed src_configure to use the Gentoo provided "myesconsargs"
> >> mechanism, to properly respect the debug USE flag
> >> - ENABLE_OPTIMIZATIONS: meanings of TRUE and FALSE are inverted here to
> >> enable this when the debug USE flag is not set and to disable it, if it
> >> is. Ugly, but I'm not sure how to achieve this otherwise.
> >> 
> >> kind regards,
> >> semkath
> > 
> > Hi
> > Thanks for your email. I have had these and some other changes in local
> > overlay since the discussion on list regarding this package. Do you still
> > get xruns with ENABLE_OPTIMIZATIONS=False and DEBUG=False? Setting
> > ENABLE_OPTIMIZATIONS adds some aggressive compiler flags and cpu detection
> > that break when doing a cross compile under portage.
> > I have no firewire devices so cannot test changes I make to this package.
> > 
> > Cheers
> > Gavin
> 
> I removed the line with ENABLE_OPTIMIZATIONS from my local ebuild and it
> seems to be working fine. I guess you can remove it since it's not
> strictly needed and if DEBUG=False libffado is built with -O2 anyway.
> Some additional changes: libffado depends (at least for the GUI mixer
> part) on python:2, python:3 will not work. I added python to the inherit
> line and added the following variables to account for this, as described
> in http://www.gentoo.org/proj/en/Python/developersguide.xml
> 
> PYTHON_DEPEND="2"
> RESTRICT_PYTHON_ABIS="3.*"
> 
> Also, I added the following to get the ebuild to work even if python:3
> is set as default:
> 
> pkg_setup() {
>      python_set_active_version 2
>      python_pkg_setup
> }
> 
> And finally, to convert the shebangs in various python files installed
> by libffado:
> 
> src_prepare() {
>      python_convert_shebangs -r 2 .
> }
> 
> best,
> semkath

Hi
Changes committed, thanks a lot for your help. Please let us know if there is 
more.

Cheers
Gavin