Re: [proaudio] zynjacku-9999

[ Thread Index | Date Index | More lists.tuxfamily.org/proaudio Archives ]


Hi Nedko,

There is many more ebuilds in this overlay, which needs to be more
correct. I think this one is no exception.

2010/10/16, Nedko Arnaudov <nedko@xxxxxxxxxxxxx>:
> IMO the zynjacku-9999 ebuild is broken. For my use I've removed these
> lines from src_install():
>
> ------------
> 	insinto /usr/lib/zynjacku
> 	doins zynjacku.so zynjacku.py zynjacku.glade
> 	fperms +x /usr/lib/zynjacku/zynjacku.py
> 	dosym /usr/share/zynjacku/gpl.txt /usr/lib/zynjacku/gpl.txt
> 	dosym /usr/bin/midi_led.py /usr/lib/zynjacku/midi_led.py
> 	make_wrapper "zynjacku" "/usr/lib/zynjacku/zynjacku.py" "/usr/lib/zynjacku"
> ------------
>
> When emerging the ebuild I get these errors (they dont stop the
> emerge):
>
> ------------
> install: cannot stat `zynjacku.so': No such file or directory
> !!! doins: zynjacku.so does not exist
> install: cannot stat `zynjacku.py': No such file or directory
> !!! doins: zynjacku.py does not exist
> chmod: cannot access
> `/var/tmp/portage/media-sound/zynjacku-9999/image//usr/lib/zynjacku/zynjacku.py':
> No such file or directory
>>>> Completed installing zynjacku-9999 into
>>>> /var/tmp/portage/media-sound/zynjacku-9999/image/
>
>  * QA Notice: file does not exist:
>  *
>  *      doins: zynjacku.so does not exist
>  *      doins: zynjacku.py does not exist
> ------------
>
> I dont understand why these additional lines were added to src_install()
> so I'm assuming that there may be a lack of ebuild knowledge on my
> side. Some of these are wrong or at least outdated because the
> installation layout has changed (normalized) as requested by a Debian
> packager (IIRC).
>
>> insinto /usr/lib/zynjacku
>> doins zynjacku.so zynjacku.py zynjacku.glade
>
>  * There is no zynjacku.so to install.
>  * There is no zynjacku.py to install.
>  * /usr/lib/ should be /usr/lib64/ on amd64
>  * zynjacku.glade is installed as /usr/share/zynjacku/zynjacku.glade by
>    the zynjacku build system. The copy in /usr/lib/zynjacku/ seems to
>    be not needed.
>
>> fperms +x /usr/lib/zynjacku/zynjacku.py
>
> There is no zynjacku.py anymore.
>
>> dosym /usr/share/zynjacku/gpl.txt /usr/lib/zynjacku/gpl.txt
>
> This symlink gets created by I dont understand why it is needed. Maybe
> zynjacku was trying to read it before (i'm too lazy to check). Or maybe
> it is some kind of a gentoo policy to have the license in /usr/lib/ ?
>
>> dosym /usr/bin/midi_led.py /usr/lib/zynjacku/midi_led.py
>
> There is no midi_led.py anymore.
>
>> make_wrapper "zynjacku" "/usr/lib/zynjacku/zynjacku.py"
>> "/usr/lib/zynjacku"
>
> This renders zynjacku unusable because it overwrites the real zynjacku
> script. lv2rack is of course not affected :)
>
> If you are ok with removing of these lines, I'll commit this change
> (should fix the zynjacku-9999.ebuild).
>
> --
> Nedko Arnaudov <GnuPG KeyID: DE1716B0>
>


-- 
WBR, Viktor



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/