Re: [pok-devel] POK/Ocarina questions

[Etienne.Zante.EXT@xxxxxxxxxxxxxxxxxxx]

Hi,

In fact to explain a little bit more
why I propose this changes, I have to say that we are currently at Zodiac
looking at POK for an architecture that is not currently supported. What
I can tell for now is that this arch is a 32 bit architecture.

When I installed the last version of
ocarina and POK, I tried the differents examples. When testing the arinc653-blackboard
I get some errors.

with the default version of ocarina,
when you use a blackboard in aadl, the result is the declaration in the
deployment.c file of the partition 1  of an uint8_t input_id. This
variable size is 8 bits except that in activity.c you get the declaration
" extern BLACKBOARD_ID_TYPE input_id;". BLACKBOARD_ID_TYPE is
define in blackboard.h as "typedef  APEX_INTEGER BLACKBOARD_ID_TYPE;"
and APEX_INTEGER is defined as long in types.h so you declare an 8 bit
variable that you call with an extern declaration as a 32 bit variable.
So you use an 8 bits as it is a 32 bits.  

You will not get error when you test
it on qemu for x86 arch but in my case I get errors and I think it's legit
to get errors on that!

In addition to that, in ocarina, you
test if you are in arinc mode or not, you set Type_Used and then you always
use Uint8_t variable. So why setting a variable and do not use it ? You
also do the same for Arinc653 buffer but I have not tested it yet.

After applying my patch, I have not
seen any error on my arch, on x86 or on LEON. I tried to find other impacts
on code but I did not find any.

I am not currently working on POK due
to other projects but I will get back to it soon.

Let me know if you disagree with my
issue or solution.

Sincerely

ZODIAC AERO ELECTRIC Zodiac Aircraft Systems Cabin & Cockpit Systems division Zodiac Cabin & Cockpit Systems BU
Etienne Zante Ingénieur d'études
7 rue des longs quartiers - Montreuil - 93 - 93100 - France Tel: +33155825364 etienne.zante.ext@xxxxxxxxxxxxxxxxxxx http://www.zodiacaerospace.com

De :      
 Julien Delange <julien@xxxxxxxxx>
A :      
 pok-devel@xxxxxxxxxxxxxxxxxxx
Date :      
 08/10/2014 03:43
Objet :    
   Re: [pok-devel]
POK/Ocarina questions
Envoyé par :    
   julien.delange@xxxxxxxxx

---

Hi Jerome,

I replied to the github issue, I am wondering if the change
if enough. I am suspecting it could then break the generated code.

Julien.


On Wed, Oct 1, 2014 at 9:33 AM, Jérôme Hugues <Jerome.HUGUES@xxxxxxx>
wrote:
Hi POK dev,

Here are some question regarding code generation from a user that may impact
POK
        https://github.com/yoogx/ocarina/issues/16

Basically, issue in type management and memory alignment issue
I’d appreciate your feedback on this

Regards,

--
Jérôme Hugues, ISAE/DMIA
Jerome.HUGUES@xxxxxxx
- (+33)
5 61 33 91 84