| [linux-oxnas] Re: [PATCH] mtd: oxnas_nand: Allocating more than necessary in probe() |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/linux-oxnas Archives
]
On 04/25/2017 11:19 AM, Dan Carpenter wrote:
> We only need to allocate sizeof(struct oxnas_nand_ctrl) which is 192
> bytes and not sizeof(struct nand_chip) which is a much larger 3056
> bytes.
>
> Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/mtd/nand/oxnas_nand.c b/drivers/mtd/nand/oxnas_nand.c
> index 3e3bf3b364d2..1b207aac840c 100644
> --- a/drivers/mtd/nand/oxnas_nand.c
> +++ b/drivers/mtd/nand/oxnas_nand.c
> @@ -91,7 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> int err = 0;
>
> /* Allocate memory for the device structure (and zero it) */
> - oxnas = devm_kzalloc(&pdev->dev, sizeof(struct nand_chip),
> + oxnas = devm_kzalloc(&pdev->dev, sizeof(*oxnas),
> GFP_KERNEL);
> if (!oxnas)
> return -ENOMEM;
>
Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>