| [linux-oxnas] Re: [GIT PULL] ARM: OXNAS SoC updates for 4.10 |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/linux-oxnas Archives
]
- To: Olof Johansson <olof@xxxxxxxxx>
- Subject: [linux-oxnas] Re: [GIT PULL] ARM: OXNAS SoC updates for 4.10
- From: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
- Date: Mon, 14 Nov 2016 15:52:36 +0100
- Cc: arm@xxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, linux-oxnas@xxxxxxxxxxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=3VzUgOV/7P4h5RCW3s2HH3KvpODxTRnDQKufbO87yUQ=; b=wjbJ1hurCx/vC75AxVQh282J6ufLg0bxPwIWgzhvlnRVVrLuC4Z4JUo0pd9gKnXgUj 676PAPQ/4bQ5TQpY4IkL/pOyleUJ1RjBnOUPVFJWQa3wmJJGJZAise57eX/FHS7cBnSS IGN6ZeH/43CO3XdOmS8V50cpyy15DZJ6+IIREmQsZY4h/Qd6QvrCVRgwWAzbfgIPgHCO VeXCoCkzdSAkas4G2urNmKFtO3g5d8J8v7ZLsZx8QI71eW96tRGdW9/6zCgfnm5fD+RY EknS8E6oPv7T5xVNDivKYLSQ2tSbDmJfPbDqYTjHYnuixxJ/evBRMbKow0Pq7MdgFmpY 552A==
- Organization: Baylibre
On 11/08/2016 12:21 PM, Neil Armstrong wrote:
> On 11/07/2016 10:26 PM, Olof Johansson wrote:
>> On Mon, Oct 31, 2016 at 10:52:53AM +0100, Neil Armstrong wrote:
[...]
>> Hi Neil,
> Hi Olof,
>
>>
>> Sorry for being picky here, please be patient with us. :-)
> Seems legit !
>
>>
>> Overall comments on this patch set:
>>
>> 1) Copyrights seem to be a bit varied. All 3 new source files have
>> different copyright holders. Only one has yours, one is from 2003, one
>> is also from 2013. Is this expected? Seems like it's worth mentioning
>> in commit messages at least.
>
> Yes, the files comes from various places :
> - hotplug.c was taken from versatile by Ma Haijun and left verbatim, so I left the original header
> - headsmp.S was taken from the versatile code and adapted by Ma Haijun
> - platsmp.c is a mix from versatile code, Ma Haijun code and my code for DT
>
> The two first file were only modified in order to build and pass checkpatch actually.
>
> I tried to find the *real* copyright holders, but it was not easy...
>
>>
>> 2) Please remove the linux/arch/... lines from the top of the files. It's
>> something we've been trying to remove for a while and don't want to
>> introduce more occurrances of.
>>
>> I'd say (2) is fine to do incremental, but please provide clarification on (1).
>> I could just add that to the merge commit message so don't respin the branch
>> yet, depending on what we hear back!
>>
>
> Ok, please tell me if/when I need to send a new pull for the (2) fix.
>
>>> arch/arm/Makefile | 1 +
>>> arch/arm/mach-oxnas/Kconfig | 30 +++++++++++++++++++---------
>>> arch/arm/mach-oxnas/Makefile | 2 ++
>>> arch/arm/mach-oxnas/headsmp.S | 28 ++++++++++++++++++++++++++
>>> arch/arm/mach-oxnas/hotplug.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> arch/arm/mach-oxnas/platsmp.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>
>> Git tip: If you redirect the output to a file (or pipe through cat), the
>> diffstat will be limited to 80 characters and look better in email.
>>
>>
>> Thanks,
>>
>> -Olof
>>
>
> Thanks,
> Neil
>
Hi Olof,
Is a new pull request needed finally ?
Best regards,
Neil