| Re: [hatari-devel] Hatari screen dialog regression |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Andreas Grabher <andreas_g86@xxxxxxxxxx>, hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Hatari screen dialog regression
- From: Eero Tamminen <oak@xxxxxxxxxxxxxx>
- Date: Thu, 21 Aug 2025 16:04:05 +0300
- Dkim-filter: OpenDKIM Filter v2.11.0 smtp.dnamail.fi 3F1474098E8C
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=helsinkinet.fi; s=2025-03; t=1755781446; bh=ns1rOZCnPWm28YctrbHfUlzDm8GOmp8DvnmlACPyk7o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=jXoI5ZKN2z+FNcVotc98Tx5yyt7ZJkRByaRn4xBimNh2dUzaibj9sVDGd2MfLwvLT NkDw0iGdHy3QdoD7I0I4VSY2jWyt7qeZN+66azobbUmHKUxndAaCZuiysxkjDwLWJI toYmYGOjm48ClH3aOJW/kK+3j8u4BQlWn/rIFBQxc46COHyKPKKZCLdTV+VzB18Dqn 70bqKixxcTE4phywoiPHBTnuOZTojBSqiMXBZ9ZCknR18MK24w+5/YU6vREPk2p7OA wKAemRSrLavCzKv5aKbesEW8umHj2igaiRXeKQm0WaO/MKagnFFfNB66S6EPLLdghm eF6VAjqF0Tt8A==
Hi Andreas,
Sorry for the late answer.
On 16.8.2025 8.01, Andreas Grabher wrote:
Does the fact that 2.6.1 has been released mean, that my patch (which I made on your request) is ignored?
No. v2.6.1 was Hatari v2.6 bug fix release (and your patch had no
impact on Hatari functionality).
Initial screen dialog change itself probably should have waited after
v2.6.1, but these things happen...
> Whoever develops with assert disabled does something wrong. Guarding
during development is the purpose of asserts.
The fact is that Hatari defaults to release build [1], CMake does those
with asserts disabled, and hides compilation commands so one won't
notice it. So it's very possible that one does not know, or has
forgotten that when coming back to project. None of us are that young
any more...
It may be better to default to (optimized) debug build with asserts
enabled, and only do release builds with asserts disabled[2], but that's
up to Nicolas.
(I don't know how Nicolas does releases.)
[1] https://github.com/hatari/hatari/blob/main/CMakeLists.txt#L6
[2] Note thatit's possible for assert-disabling to uncover bugs too.
On 16.8.2025 7.54, Andreas Grabher wrote:
>> If you remember it... And Hatari has lot of options affecting screen
size, that one would need to remember.
To clarify, "you" in above was referring to us on the Hatari mailing
list (not you personally), as in "If one remembers it".
> This is nothing I need to remember. This is a logical testing routine.
Stating after issue has been already debugged & fixed, that unlike
project members, you would have done things perfectly, is very credible,
thank you. :-)
- Eero