Fwd: [hatari-devel] Hatari screen dialog regression (size warnings)

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


>> Am 13.08.2025 um 21:25 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>>>>> Am 13.08.2025 um 21:21 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>>>>> Doesn't Previous have user configuration options that affect its window size?
>>>>> 
>>> It has not. If it had I would test my code with the smallest possible window size.
> 
> If you remember it... And Hatari has lot of options affecting screen size, that one would need to remember.
> 
This is nothing I need to remember. This is a logical testing routine.

>> This is not a runtime issue but a coding issue. If this is really needed it would be a bit less ugly to use assert() instead of comparing hard coded values at runtime on user’s machines. The result will always be the same.
> 
> I considered that, but the problem with asserts is that:
> * Assers terminate the process, so one cannot view problematic dialog if asserts are enabled
> * Contributor may do builds with asserts disabled (that's CMake default for release builds), and we want contributor to see the issue before sending a patch
> 
Whoever develops with assert disabled does something wrong. Guarding during development is the purpose of asserts. When the process terminates you usually get a call stack that points you to the faulty dialog.
> 
>   - Eero
> 



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/