Fwd: [hatari-devel] Hatari screen dialog regression (size warnings) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Hatari devel list <hatari-devel@xxxxxxxxxxxxxxxxxxx>
- Subject: Fwd: [hatari-devel] Hatari screen dialog regression (size warnings)
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Sat, 16 Aug 2025 07:04:23 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=TF59VxGjfJ0/zSH/dQ7YJK+mvpj7jNAZszG2C/cmBh0=; h=Content-Type:From:Mime-Version:Date:Subject:Message-Id:To:x-icloud-hme; b=SsB30qCa7tXaLxUWttLYjHWnZeW6L3kkUICI/R299rd9S34AMowJPYg7IEVX/Mqm05I2JxhaEkZxqf3eRy8jLLXEHTMoMNYTdCTdUAJXQ8LAK7/LYCwOLxttztcWNN4JVsO4OChKGFxJVITecBDRyHO31IztTho+mm9e8Fe0+5HnIkNboxVpYRgl556FA46/4iT4gRJi4WTayIv6npzysQPMZ7j/QObCgtRh2ijDlZp4xAO5KtdlgiCqEytjK7FN7pfCYA5uX7hRzOpSZQ45dDveUCf1uEaGHAxmufF1KAMu1A/HJhcjp1Wf5U7O9fjam67XGh66zkC1wHAGZQTrPg==
>> Am 13.08.2025 um 21:25 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>>>>> Am 13.08.2025 um 21:21 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>>>>> Doesn't Previous have user configuration options that affect its window size?
>>>>>
>>> It has not. If it had I would test my code with the smallest possible window size.
>
> If you remember it... And Hatari has lot of options affecting screen size, that one would need to remember.
>
This is nothing I need to remember. This is a logical testing routine.
>> This is not a runtime issue but a coding issue. If this is really needed it would be a bit less ugly to use assert() instead of comparing hard coded values at runtime on user’s machines. The result will always be the same.
>
> I considered that, but the problem with asserts is that:
> * Assers terminate the process, so one cannot view problematic dialog if asserts are enabled
> * Contributor may do builds with asserts disabled (that's CMake default for release builds), and we want contributor to see the issue before sending a patch
>
Whoever develops with assert disabled does something wrong. Guarding during development is the purpose of asserts. When the process terminates you usually get a call stack that points you to the faulty dialog.
>
> - Eero
>