| Re: [hatari-devel] Hatari screen dialog regression |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Hatari screen dialog regression
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Thu, 7 Aug 2025 22:55:32 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=3tJz1t809+iiMFHXS/FVh2C04OAJYipf3yImQqpGzcA=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id:x-icloud-hme; b=EHasEm0CSGuQGm9MWGMc7D6NdjNI8rI4JgCxaF305HeObzXjNAKAOaS8mlSmp24vAQfRFHAAJb1uJJiSXUTqzerU9pE5OUs7Exp1OPJesGci6n+FRUp6+xVaoFvYZVun99Z3RZnkH7J6wZFO6uxhul9h0Xvs2w0DlBLN+Nze1WAkQpKsYya37+vrdWpmSSeqGo4FkPTJChOlUvDu8PVowZvgiM8xkyTbijvL1SHEn6X8OoQ0SguFXxgCeAIS7iDuXkbf3IWoZZaAEkLu6oyj0TAQCJQR/8nRHp0Q2bmqfK4CtlE9Swe83kPizYw0WTNXPXSJEgBy44Xybfj2CIBkuA==
> Am 07.08.2025 um 22:21 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>
> Hi,
>
> As there were no other comments I pushed (slightly updated version) of the patch series.
>
> - Eero
>
> On 5.8.2025 23.30, Eero Tamminen wrote:
>> On 2.8.2025 23.24, Nicolas Pomarède wrote:
>>> looking at the patches, they look ok to me. But as there's also a lot of changes, I don't have time at the moment to check all the possible situations where these patches could change the behaviour when using Hatari and its UI.
>>>
>>> I guess you tested them and they work, so on my side I'm ok to push these if you think everything is complete.
>> I've tested changes related to AVI & screenshot saving functionality, but not everything related to options.c changes in the "Support for checking whether given option dir exists" patch, so it would be good to check that more closely.
>> Thomas, could you check the patch series too?
>> - Eero
>
>
I just checked the patches to see what would need to be merged into Previous. I recognised that configuration handling is done in paths.c now. I don’t think it is a good idea to increase dependencies this way. It would be better to create a function in configuration like Configuration_GetScreenShotDir() which returns either the default or the user selected directory. That way paths.c can be untouched and code structure is more logical.
Hatari has a quite good code structure, but it seems to get eroded more and more over time. I think it is a win-win situation if portability is taken into account when editing the source files. (H)Atari-specific code should not go into common files.
Regards
Andreas