| Re: [hatari-devel] Doing Hatari 2.6.1 release |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Doing Hatari 2.6.1 release
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Sun, 20 Jul 2025 09:13:12 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=N8LbaX9REe9ML/cdhFD50UxOmRYfnGoehCqwba1zci8=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id:x-icloud-hme; b=qPPH4h3IfqAtihVTk6Zu84H6JDoJHnR+THxpej8tuUl/cRhjHg/8P3gR9QCFuOhU4VZ6AayzLYlmZiSxr9vsn9rvTbdyp0u2kbFyZRZmagNsFT443dYZmDsqVOiPaOj2e4dGMV/iLmWVfAM/09o6LBa1wZZu4GifGJwplcwgk2uPajDxnKJVtfc2wDqXjxZFMHoVElvL9uSo2VnU3aCyQduQz6rh4Rcy8y4MXPK8wghP5jYJ0p+Vl08YRgiK6zdI83aEtIaWfuKe9oM6astnrINwDDBjwGKGvNZkSwskUdaGwVNVcrtZ4svdM9r4dX1uw2PjArnCRvmFC2uI+kO+Vg==
It depends on what you do with the path string. The GUI itself will work for the most part (I think except for showing no directory icons; but the icons are meaningless anyway; probably should be redesigned to show files or folders). I have no machine for testing, so I am not sure about that.
Anyway as soon as you call stat() with one of the path strings it will fail. Is it really a good idea to keep this? This can cause very hard to debug issues in the future. stat() does not tell you what’s wrong (just reporting ENOENT). I only found the problem because I have been reading about trailing slashes some time before in a different context. I was lucky.
I don’t think it depends on the toolchain. I am using the same CMake files as Hatari does. The user reporting the issues is using MinGW for compilation. The Microsoft documentation that I linked to earlier is not specific to some special conditions. It seems to be a general issue.
> Am 20.07.2025 um 08:54 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
>
> Am Sat, 19 Jul 2025 22:46:38 +0200
> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>
>> I really think the trailing backslash issue should be fixed.
>
> We've got LFS support in Hatari since many years already, so I'm wondering
> why none of our Windows users has complained about this ever...?
> Maybe it's only related to your toolchain / Previous?
>
>>> Am 19.07.2025 um 22:44 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>>>
>>> Le 08/07/2025 à 19:01, Nicolas Pomarède a écrit :
>>>> Hi
>>>> seeing the few reports we got since releasing 2.6.0 and the fixes that were already done or are incoming, I think it could be possible do a 2.6.1 release soon, maybe before end of july.
>>>> So, let's not push big changes for the moment to the git repo, small new changes are possible, in order to limit possible new regression when we do 2.6.1
>>>
>>> some changes were pushed already, any more pending stuff that could go into 2.6.1 ?
>
> I've got nothing pending for 2.6.1 right now, so from my side, you can go
> ahead!
>
> Thomas
>
>