Re: [hatari-devel] Improve directory handling patch

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 7.7.2025 12.33, Frederic Poeydomenge wrote:
> I have made my first contribution to the Hatari project : this is an
> improvement to the interface that allows configuring the folder containing
> screenshots and videos, covering the "Improve directory handling" section
> in doc/todo.txt

Thanks, this is much appreciated!


[...]
> If I have missed any details or if modifications are needed, please let me
> know. I tried to be as thorough as possible, but some things may have
> escaped my attention.

On quick glance, the patch seems in general good, but there are couple 
of things which need to be updated:

* AviRecordFile is likely to be a full path in users' existing config 
files, so just concatenating it to screenshot dir as-is is unlikely to 
be what's expected. Maybe take basename from it, and if that's empty, 
use some default name?

* Instead of hard-coding 32 for GUI dir name size, use sizeof()


Also, changing screenshot saving messages to use log facilities and INFO 
log level is correct good / correct.  However, only LOG_WARN or higher 
is shown by default, and I wonder whether users still expect to see 
where the files were saved, so that those paths can be copy-pasted from 
console e.g. to browser file selector.

Any opinions from the other list members?


	- Eero