Re: [hatari-devel] Seeing Hatari help on Windows?

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi Andreas,

On 7.6.2025 9.25, Andreas Grabher wrote:
> > Am 07.06.2025 um 08:19 schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> > In screen.c after "if (!sdlscrn)" SDL_Quit() is called before SDL_GetError(). That clears the error before reporting and SDL_GetError() returns an empty string. I tested this by calling SDL_Quit() after failing to create a renderer (it was easier to force a failure in renderer creation, than in surface creation). I get this message without calling SDL_Quit():
> > ERROR: Failed to create renderer:
> > 	testrenderer not available
> >
> > And this message with calling SDL_Quit() right before Main_ErrorExit():
> > ERROR: Failed to create renderer:
> >
> > I suggest this fix:
> > Call SDL_Quit() from Main_ErrorExit() right before exit(errval) and remove the call from screen.c. The documentation for SDL_Quit() states: "It is safe to call this function even in the case of errors in initialization.“. So this should always work.

Thanks for testing!  I applied/pushed your suggestion.

(Another alternative would have been just using a temporary variable for 
he error message, but SDL_Quit() usage was quite inconsistent, so I 
think just doing it unconditionally on error exit is better.)


> btw.
>
> Please also fix these messages (you use "initialise" everywhere else, missing semicolon, other error messages start with capital letters):
>
> "logging/tracing initialization failed" -> "Logging/tracing initialisation failed:“
>
> "could not initialize the SDL library:" -> "Could not initialise the SDL library:"

I fixed the capitalization, but the semicolon is used only when there's 
a second (details) message given.

And the American spelling is used much more than the British one:
$ for i in initialise initialize; do
  echo "$i: $(git grep $i | wc -l)";
done
initialise: 17
initialize: 94

=> not going to change that either.


	- Eero

> > > Am 06.06.2025 um 22:56 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > >
> > > Hi,
> > >
> > > On 6.6.2025 22.02, Christian Zietz wrote:
> > > > I noticed something that I missed during my testing yesterday, though. The message says "press a key to exit". However, it will only exit when I press the return/enter key, not when pressing other keys. I assume (but don't know for sure) that this happens because stdin is line- buffered. Quick fix: reword the message.
> > >
> > > In case it's toolchain / Windows lib specific, do you have any idea whether you're using same toolchain / libs as what the Hatari releases use?
> > >
> > > (I have some faint recollection that Nicolas would do release build with Windows cross-compile from Linux using MinGW, but I'm not sure.)
> > >
> > > If yes, sure, that would be the best fix.
> > >
> > >
> > > 	- Eero