| [PATCH 19/20] Silence compiler warnings |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- Subject: [PATCH 19/20] Silence compiler warnings
- From: Thomas Huth <huth@xxxxxxxxxxxxx>
- Date: Sat, 3 Feb 2024 18:44:37 +0100
---
src/jaguar/blitter.c | 34 +++----
src/jaguar/cdintf.c | 9 +-
src/jaguar/cdrom.c | 2 +-
src/jaguar/dac.c | 10 +-
src/jaguar/dsp.c | 23 ++---
src/jaguar/eeprom.c | 18 +++-
src/jaguar/file.c | 224 +------------------------------------------
src/jaguar/gpu.c | 10 +-
src/jaguar/jagdasm.c | 10 +-
src/jaguar/jaguar.c | 8 +-
src/jaguar/jerry.c | 5 +-
src/jaguar/m68k.h | 1 +
src/jaguar/objectp.c | 24 +++--
src/jaguar/tom.c | 17 ++--
14 files changed, 88 insertions(+), 307 deletions(-)
diff --git a/src/jaguar/blitter.c b/src/jaguar/blitter.c
index 4081f1cf..74262e71 100644
--- a/src/jaguar/blitter.c
+++ b/src/jaguar/blitter.c
@@ -1650,21 +1650,21 @@ void BlitterWriteByte(uint32 offset, uint8 data, uint32 who/*=UNKNOWN*/)
// It looks weird, but this is how the 64 bit registers are actually handled...!
- else if ((offset >= SRCDATA + 0) && (offset <= SRCDATA + 3)
- || (offset >= DSTDATA + 0) && (offset <= DSTDATA + 3)
- || (offset >= DSTZ + 0) && (offset <= DSTZ + 3)
- || (offset >= SRCZINT + 0) && (offset <= SRCZINT + 3)
- || (offset >= SRCZFRAC + 0) && (offset <= SRCZFRAC + 3)
- || (offset >= PATTERNDATA + 0) && (offset <= PATTERNDATA + 3))
+ else if ((offset >= SRCDATA + 0 && offset <= SRCDATA + 3)
+ || (offset >= DSTDATA + 0 && offset <= DSTDATA + 3)
+ || (offset >= DSTZ + 0 && offset <= DSTZ + 3)
+ || (offset >= SRCZINT + 0 && offset <= SRCZINT + 3)
+ || (offset >= SRCZFRAC + 0 && offset <= SRCZFRAC + 3)
+ || (offset >= PATTERNDATA + 0 && offset <= PATTERNDATA + 3))
{
blitter_ram[offset + 4] = data;
}
- else if ((offset >= SRCDATA + 4) && (offset <= SRCDATA + 7)
- || (offset >= DSTDATA + 4) && (offset <= DSTDATA + 7)
- || (offset >= DSTZ + 4) && (offset <= DSTZ + 7)
- || (offset >= SRCZINT + 4) && (offset <= SRCZINT + 7)
- || (offset >= SRCZFRAC + 4) && (offset <= SRCZFRAC + 7)
- || (offset >= PATTERNDATA + 4) && (offset <= PATTERNDATA + 7))
+ else if ((offset >= SRCDATA + 4 && offset <= SRCDATA + 7)
+ || (offset >= DSTDATA + 4 && offset <= DSTDATA + 7)
+ || (offset >= DSTZ + 4 && offset <= DSTZ + 7)
+ || (offset >= SRCZINT + 4 && offset <= SRCZINT + 7)
+ || (offset >= SRCZFRAC + 4 && offset <= SRCZFRAC + 7)
+ || (offset >= PATTERNDATA + 4 && offset <= PATTERNDATA + 7))
{
blitter_ram[offset - 4] = data;
}
@@ -2820,7 +2820,7 @@ fflush(stdout);
// Lines that don't exist in Jaguar I (and will never be asserted)
bool polygon = false, datinit = false, a1_stepld = false, a2_stepld = false, ext_int = false;
- bool istepadd = false, istepfadd = false, finneradd = false, inneradd = false;
+ bool istepadd = false, istepfadd = false;
bool zstepfadd = false, zstepadd = false;
// Various state lines (initial state--basically the reset state of the FDSYNCs)
@@ -3550,7 +3550,7 @@ A2ptrldi := NAN2 (a2ptrldi, a2update\, a2pldt);*/
// Some more from DCONTROL...
// atick[] just MAY be important here! We're assuming it's true and dropping the term...
// That will probably screw up some of the lower terms that seem to rely on the timing of it...
-#warning srcdreadd is not properly initialized!
+// TODO: srcdreadd is not properly initialized!
bool srcdreadd = false; // Set in INNER.NET
//Shadeadd\ := NAN2H (shadeadd\, dwrite, srcshade);
//Shadeadd := INV2 (shadeadd, shadeadd\);
@@ -3968,7 +3968,7 @@ fflush(stdout);
int8 inct = -((dsta2 ? a2_x : a1_x) & 0x07); // From INNER_CNT
uint8 inc = 0;
inc = (!phrase_mode || (phrase_mode && (inct & 0x01)) ? 0x01 : 0x00);
- inc |= (phrase_mode && (((pixsize == 3 || pixsize == 4) && (inct & 0x02)) || pixsize == 5 && !(inct & 0x01)) ? 0x02 : 0x00);
+ inc |= (phrase_mode && (((pixsize == 3 || pixsize == 4) && (inct & 0x02)) || (pixsize == 5 && !(inct & 0x01))) ? 0x02 : 0x00);
inc |= (phrase_mode && ((pixsize == 3 && (inct & 0x04)) || (pixsize == 4 && !(inct & 0x03))) ? 0x04 : 0x00);
inc |= (phrase_mode && pixsize == 3 && !(inct & 0x07) ? 0x08 : 0x00);
@@ -4431,7 +4431,7 @@ printf(" Entering A1_ADD state [a1_x=%04X, a1_y=%04X, addasel=%X, addbsel=%X, m
fflush(stdout);
}
#endif
-int16 adda_x, adda_y, addb_x, addb_y, data_x, data_y, addq_x, addq_y;
+int16 adda_x, adda_y, addb_x, addb_y, addq_x, addq_y;
ADDAMUX(&adda_x, &adda_y, addasel, a1_step_x, a1_step_y, a1_stepf_x, a1_stepf_y, a2_step_x, a2_step_y,
a1_inc_x, a1_inc_y, a1_incf_x, a1_incf_y, adda_xconst, adda_yconst, addareg, suba_x, suba_y);
ADDBMUX(&addb_x, &addb_y, addbsel, a1_x, a1_y, a2_x, a2_y, a1_frac_x, a1_frac_y);
@@ -4487,7 +4487,7 @@ fflush(stdout);
//void ADDRADD(int16 &addq_x, int16 &addq_y, bool a1fracldi,
// int16 adda_x, int16 adda_y, int16 addb_x, int16 addb_y, uint8 modx, bool suba_x, bool suba_y)
//void DATAMUX(int16 &data_x, int16 &data_y, uint32 gpu_din, int16 addq_x, int16 addq_y, bool addqsel)
-int16 adda_x, adda_y, addb_x, addb_y, data_x, data_y, addq_x, addq_y;
+int16 adda_x, adda_y, addb_x, addb_y, addq_x, addq_y;
ADDAMUX(&adda_x, &adda_y, addasel, a1_step_x, a1_step_y, a1_stepf_x, a1_stepf_y, a2_step_x, a2_step_y,
a1_inc_x, a1_inc_y, a1_incf_x, a1_incf_y, adda_xconst, adda_yconst, addareg, suba_x, suba_y);
ADDBMUX(&addb_x, &addb_y, addbsel, a1_x, a1_y, a2_x, a2_y, a1_frac_x, a1_frac_y);
diff --git a/src/jaguar/cdintf.c b/src/jaguar/cdintf.c
index 93dd1df8..a16ba258 100644
--- a/src/jaguar/cdintf.c
+++ b/src/jaguar/cdintf.c
@@ -92,7 +92,6 @@ void CDIntfDone(void)
bool CDIntfReadBlock(uint32 sector, uint8 * buffer)
{
-#warning "!!! FIX !!! CDIntfReadBlock not implemented!"
// !!! FIX !!!
WriteLog("CDINTF: ReadBlock unimplemented!\n");
return false;
@@ -100,7 +99,6 @@ bool CDIntfReadBlock(uint32 sector, uint8 * buffer)
uint32 CDIntfGetNumSessions(void)
{
-#warning "!!! FIX !!! CDIntfGetNumSessions not implemented!"
// !!! FIX !!!
// Still need relevant code here... !!! FIX !!!
return 2;
@@ -108,14 +106,12 @@ uint32 CDIntfGetNumSessions(void)
void CDIntfSelectDrive(uint32 driveNum)
{
-#warning "!!! FIX !!! CDIntfSelectDrive not implemented!"
// !!! FIX !!!
WriteLog("CDINTF: SelectDrive unimplemented!\n");
}
uint32 CDIntfGetCurrentDrive(void)
{
-#warning "!!! FIX !!! CDIntfGetCurrentDrive not implemented!"
// !!! FIX !!!
WriteLog("CDINTF: GetCurrentDrive unimplemented!\n");
return 0;
@@ -123,7 +119,6 @@ uint32 CDIntfGetCurrentDrive(void)
const uint8 * CDIntfGetDriveName(uint32 driveNum)
{
-#warning "!!! FIX !!! CDIntfGetDriveName driveNum is currently ignored!"
// driveNum is currently ignored... !!! FIX !!!
#ifdef HAVE_LIB_CDIO
@@ -132,13 +127,12 @@ const uint8 * CDIntfGetDriveName(uint32 driveNum)
return driveName;
#else
- return (uint8 *)"NONE";
+ return (const uint8 *)"NONE";
#endif
}
uint8 CDIntfGetSessionInfo(uint32 session, uint32 offset)
{
-#warning "!!! FIX !!! CDIntfGetSessionInfo not implemented!"
// !!! FIX !!!
WriteLog("CDINTF: GetSessionInfo unimplemented!\n");
return 0xFF;
@@ -146,7 +140,6 @@ uint8 CDIntfGetSessionInfo(uint32 session, uint32 offset)
uint8 CDIntfGetTrackInfo(uint32 track, uint32 offset)
{
-#warning "!!! FIX !!! CDIntfTrackInfo not implemented!"
// !!! FIX !!!
WriteLog("CDINTF: GetTrackInfo unimplemented!\n");
return 0xFF;
diff --git a/src/jaguar/cdrom.c b/src/jaguar/cdrom.c
index 84a28b9d..4dc48c00 100644
--- a/src/jaguar/cdrom.c
+++ b/src/jaguar/cdrom.c
@@ -328,7 +328,7 @@ uint16 CDROMReadWord(uint32 offset, uint32 who/*=UNKNOWN*/)
case 5:
data = 0x0400;
}//*/
- WriteLog("CDROM: Reading DS_DATA (???), cdCmd=$%04X\n", cdCmd);
+ WriteLog("CDROM: Reading DS_DATA (?), cdCmd=$%04X\n", cdCmd);
}
else if ((cdCmd & 0xFF00) == 0x0200) // Stop CD
{
diff --git a/src/jaguar/dac.c b/src/jaguar/dac.c
index fc39339c..11b424f1 100644
--- a/src/jaguar/dac.c
+++ b/src/jaguar/dac.c
@@ -230,7 +230,6 @@ WriteLog("Tail=%X, Head=%X", ltail, lhead);
WriteLog("From while: Tail=%X, Head=%X", (LeftFIFOTailPtr + 2) & (BUFFER_SIZE - 1), LeftFIFOHeadPtr);
// LogDone();
// exit(0);
-#warning "Reimplement GUICrashGracefully!"
// GUICrashGracefully("Stuck in left DAC spinlock!");
return;
}
@@ -255,8 +254,6 @@ Aborting!
Tail=681, Head=681, BUFFER_SIZE-1=FFFF
From while: Tail=683, Head=681
-????? What the FUCK ?????
-
& when I uncomment the lines below spin++; it *doesn't* lock here... WTF?????
I think it was missing parentheses causing the fuckup... Seems to work now...
@@ -301,8 +298,8 @@ LTail=60D8, LHead=60D8, BUFFER_SIZE-1=FFFF
RTail=DB, RHead=60D9, BUFFER_SIZE-1=FFFF
From while: Tail=60DA, Head=60D8
*/
-#warning Spinlock problem--!!! FIX !!!
-#warning Odd: The right FIFO is empty, but the left FIFO is full!
+// TODO: Spinlock problem--!!! FIX !!!
+// Odd: The right FIFO is empty, but the left FIFO is full!
// Spin until buffer has been drained (for too fast processors!)...
uint32 spin = 0;
while (((RightFIFOTailPtr + 2) & (BUFFER_SIZE - 1)) == RightFIFOHeadPtr)//;
@@ -322,7 +319,6 @@ WriteLog("Tail=%X, Head=%X", rtail, rhead);
WriteLog("From while: Tail=%X, Head=%X", (RightFIFOTailPtr + 2) & (BUFFER_SIZE - 1), RightFIFOHeadPtr);
// LogDone();
// exit(0);
-#warning "Reimplement GUICrashGracefully!"
// GUICrashGracefully("Stuck in right DAC spinlock!");
return;
}
@@ -357,11 +353,9 @@ WriteLog("Tail=%X, Head=%X", rtail, rhead);
if (SDL_OpenAudio(&desired, NULL) < 0) // NULL means SDL guarantees what we want
{
// This is bad, Bad, BAD !!! DON'T ABORT BECAUSE WE DIDN'T GET OUR FREQ! !!! FIX !!!
-#warning !!! FIX !!! Aborting because of SDL audio problem is bad!
WriteLog("DAC: Failed to initialize SDL sound: %s.\nDesired freq: %u\nShutting down!\n", SDL_GetError(), desired.freq);
// LogDone();
// exit(1);
-#warning "Reimplement GUICrashGracefully!"
// GUICrashGracefully("Failed to initialize SDL sound!");
return;
}
diff --git a/src/jaguar/dsp.c b/src/jaguar/dsp.c
index 99b8cf29..c45449ab 100644
--- a/src/jaguar/dsp.c
+++ b/src/jaguar/dsp.c
@@ -325,7 +325,7 @@ uint8 dsp_opcode_cycles[64] =
1, 1, 3, 3, 1, 1, 1, 1
};//*/
-void (* dsp_opcode[64])() =
+void (* dsp_opcode[64])(void) =
{
dsp_opcode_add, dsp_opcode_addc, dsp_opcode_addq, dsp_opcode_addqt,
dsp_opcode_sub, dsp_opcode_subc, dsp_opcode_subq, dsp_opcode_subqt,
@@ -432,7 +432,7 @@ void DSPDumpDisassembly(void);
void FlushDSPPipeline(void);
-void dsp_reset_stats(void)
+static void dsp_reset_stats(void)
{
for(int i=0; i<65; i++)
dsp_opcode_use[i] = 0;
@@ -444,7 +444,7 @@ void DSPReleaseTimeslice(void)
dsp_releaseTimeSlice_flag = 1;
}
-void dsp_build_branch_condition_table(void)
+static void dsp_build_branch_condition_table(void)
{
// Allocate the mirror table
if (!mirror_table)
@@ -1114,7 +1114,7 @@ ctrl2[0] = regs2[30] = dsp_pc;
//
// Non-pipelined version...
//
-void DSPHandleIRQsNP(void)
+static void DSPHandleIRQsNP(void)
{
//CC only!
#ifdef DSP_DEBUG_CC
@@ -1327,7 +1327,7 @@ void DSPDone(void)
WriteLog("DSP: pending=%08X enabled=%08X\n", bits, mask);
WriteLog("\nRegisters bank 0\n");
- for(int j=0; j<8; j++)
+ for (j = 0; j < 8; j++)
{
WriteLog("\tR%02i=%08X R%02i=%08X R%02i=%08X R%02i=%08X\n",
(j << 2) + 0, dsp_reg_bank_0[(j << 2) + 0],
@@ -2713,7 +2713,7 @@ static void DSP_subqmod(void);
static void DSP_subqt(void);
static void DSP_xor(void);
-void (* DSPOpcode[64])() =
+void (* DSPOpcode[64])(void) =
{
DSP_add, DSP_addc, DSP_addq, DSP_addqt,
DSP_sub, DSP_subc, DSP_subq, DSP_subqt,
@@ -3051,7 +3051,7 @@ F1B1FC: MOVEI #$00F1A100, R01 [NCZ:001, R01=00F1A100] -> [NCZ:001, R01=00F1A100
uint32 pcQueue1[0x400];
uint32 pcQPtr1 = 0;
-static uint32 prevR1;
+
//Let's try a 3 stage pipeline....
//Looks like 3 stage is correct, otherwise bad things happen...
void DSPExecP2(int32 cycles)
@@ -3081,9 +3081,6 @@ if (dsp_pc == 0xF1B092)
doDSPDis = true;//*/
/*if (dsp_pc == 0xF1B0D2) && dsp_reg[1] == 0x2140C)
doDSPDis = true;//*/
-//Two parter... (not sure how to write this)
-//if (dsp_pc == 0xF1B0D2)
-// prevR1 = dsp_reg[1];
//F1B0D2: ADDQT #8, R01 [NCZ:000, R01=0002140C] -> [NCZ:000, R01=00021414]
//F1B0D2: ADDQT #8, R01 [NCZ:000, R01=0002140C] -> [NCZ:000, R01=00021414]
@@ -3290,9 +3287,9 @@ WriteLog("\n");
}
// Push instructions through the pipeline...
- plPtrRead = (++plPtrRead) & 0x03;
- plPtrExec = (++plPtrExec) & 0x03;
- plPtrWrite = (++plPtrWrite) & 0x03;
+ plPtrRead = (plPtrRead + 1) & 0x03;
+ plPtrExec = (plPtrExec + 1) & 0x03;
+ plPtrWrite = (plPtrWrite + 1) & 0x03;
}
dsp_in_exec--;
diff --git a/src/jaguar/eeprom.c b/src/jaguar/eeprom.c
index 266a11ae..272755a2 100644
--- a/src/jaguar/eeprom.c
+++ b/src/jaguar/eeprom.c
@@ -50,20 +50,28 @@ static uint16 jerry_ee_data = 0;
static uint16 jerry_ee_data_cnt = 16;
static uint16 jerry_writes_enabled = 0;
static uint16 jerry_ee_direct_jump = 0;
-static char eeprom_filename[MAX_PATH];
+static char eeprom_filename[MAX_PATH + 12];
static bool foundEEPROM = false;
void EepromInit(void)
{
- sprintf(eeprom_filename, "%s%08X.eep", vjs.EEPROMPath, (unsigned int)jaguarMainROMCRC32);
+ snprintf(eeprom_filename, sizeof(eeprom_filename), "%s%08X.eep",
+ vjs.EEPROMPath, (unsigned int)jaguarMainROMCRC32);
FILE * fp = fopen(eeprom_filename, "rb");
if (fp)
{
- fread(eeprom_ram, 1, 128, fp);
+ if (fread(eeprom_ram, 1, 128, fp) == 128)
+ {
+ WriteLog("EEPROM: Loaded from %s\n", eeprom_filename);
+ foundEEPROM = true;
+ }
+ else
+ {
+ WriteLog("EEPROM: Failed to load full file from %s\n",
+ eeprom_filename);
+ }
fclose(fp);
- WriteLog("EEPROM: Loaded from %s\n", eeprom_filename);
- foundEEPROM = true;
}
else
WriteLog("EEPROM: Could not open file \"%s\"!\n", eeprom_filename);
diff --git a/src/jaguar/file.c b/src/jaguar/file.c
index def7634d..70e57dff 100644
--- a/src/jaguar/file.c
+++ b/src/jaguar/file.c
@@ -17,6 +17,7 @@
#include <stdarg.h>
#include <string.h>
+#include <stdlib.h>
#include "crc32.h"
#include "eeprom.h"
#include "jaguar.h"
@@ -28,7 +29,7 @@
// Private function prototypes
static int gzfilelength(gzFile gd);
-static bool CheckExtension(const char * filename, const char * ext);
+//static bool CheckExtension(const char * filename, const char * ext);
static int ParseFileType(uint8 header1, uint8 header2, uint32 size);
// Private variables/enums
@@ -44,7 +45,6 @@ uint32 JaguarLoadROM(uint8 * rom, char * path)
{
// We really should have some kind of sanity checking for the ROM size here to prevent
// a buffer overflow... !!! FIX !!!
-#warning "!!! FIX !!! Should have sanity checking for ROM size to prevent buffer overflow!"
uint32 romSize = 0;
WriteLog("JaguarLoadROM: Attempting to load file '%s'...", path);
@@ -102,219 +102,6 @@ uint32 JaguarLoadROM(uint8 * rom, char * path)
return romSize;
}
-//
-// Jaguar file loading
-//
-bool JaguarLoadFileOld(char * path)
-{
- jaguarROMSize = JaguarLoadROM(jaguarMainROM, path);
-
- if (jaguarROMSize == 0)
- {
-// WriteLog("VJ: Could not load ROM from file \"%s\"...\nAborting!\n", newPath);
- WriteLog("GUI: Could not load ROM from file \"%s\"...\nAborting load!\n", path);
-#warning "!!! Need error dialog here !!!"
-// Need to do something else here, like throw up an error dialog instead of aborting. !!! FIX !!!
-// log_done();
-// exit(0);
- return false; // This is a start...
- }
-
- jaguarMainROMCRC32 = crc32_calcCheckSum(jaguarMainROM, jaguarROMSize);
- WriteLog("CRC: %08X\n", (unsigned int)jaguarMainROMCRC32);
- EepromInit();
-
- jaguarRunAddress = 0x802000;
-
- char * ext = strrchr(path, '.'); // Get the file's extension for non-cartridge checking
-
-//NOTE: Should fix JaguarLoadROM() to replace .zip with what's *in* the zip (.abs, .j64, etc.)
-#warning "!!! Need more robust file type checking in JaguarLoadROM() !!!"
- if (strcasecmp(ext, ".rom") == 0)
- {
- // File extension ".ROM": Alpine image that loads/runs at $802000
- WriteLog("GUI: Setting up homebrew (ROM)... Run address: 00802000, length: %08X\n", jaguarROMSize);
-
- for(int i=jaguarROMSize-1; i>=0; i--)
- jaguarMainROM[0x2000 + i] = jaguarMainROM[i];
-
- memset(jaguarMainROM, 0xFF, 0x2000);
-/* memcpy(jaguar_mainRam, jaguar_mainRom, jaguarRomSize);
- memset(jaguar_mainRom, 0xFF, 0x600000);
- memcpy(jaguar_mainRom + 0x2000, jaguar_mainRam, jaguarRomSize);
- memset(jaguar_mainRam, 0x00, 0x400000);*/
-
-/*
-Stubulator ROM vectors...
-handler 001 at $00E00008
-handler 002 at $00E008DE
-handler 003 at $00E008E2
-handler 004 at $00E008E6
-handler 005 at $00E008EA
-handler 006 at $00E008EE
-handler 007 at $00E008F2
-handler 008 at $00E0054A
-handler 009 at $00E008FA
-handler 010 at $00000000
-handler 011 at $00000000
-handler 012 at $00E008FE
-handler 013 at $00E00902
-handler 014 at $00E00906
-handler 015 at $00E0090A
-handler 016 at $00E0090E
-handler 017 at $00E00912
-handler 018 at $00E00916
-handler 019 at $00E0091A
-handler 020 at $00E0091E
-handler 021 at $00E00922
-handler 022 at $00E00926
-handler 023 at $00E0092A
-handler 024 at $00E0092E
-handler 025 at $00E0107A
-handler 026 at $00E0107A
-handler 027 at $00E0107A
-handler 028 at $00E008DA
-handler 029 at $00E0107A
-handler 030 at $00E0107A
-handler 031 at $00E0107A
-handler 032 at $00000000
-
-Let's try setting up the illegal instruction vector for a stubulated jaguar...
-*/
-/* SET32(jaguar_mainRam, 0x08, 0x00E008DE);
- SET32(jaguar_mainRam, 0x0C, 0x00E008E2);
- SET32(jaguar_mainRam, 0x10, 0x00E008E6); // <-- Should be here (it is)...
- SET32(jaguar_mainRam, 0x14, 0x00E008EA);//*/
-
- // Try setting the vector to say, $1000 and putting an instruction there that loops forever:
- // This kludge works! Yeah!
- SET32(jaguarMainRAM, 0x10, 0x00001000);
- SET16(jaguarMainRAM, 0x1000, 0x60FE); // Here: bra Here
- }
- else if (strcasecmp(ext, ".abs") == 0)
- {
- // File extension ".ABS": Atari linker output file with header (w/o is useless to us here)
-
-/*
-ABS Format sleuthing (LBUGDEMO.ABS):
-
-000000 60 1B 00 00 05 0C 00 04 62 C0 00 00 04 28 00 00
-000010 12 A6 00 00 00 00 00 80 20 00 FF FF 00 80 25 0C
-000020 00 00 40 00
-
-DRI-format file detected...
-Text segment size = 0x0000050c bytes
-Data segment size = 0x000462c0 bytes
-BSS Segment size = 0x00000428 bytes
-Symbol Table size = 0x000012a6 bytes
-Absolute Address for text segment = 0x00802000
-Absolute Address for data segment = 0x0080250c
-Absolute Address for BSS segment = 0x00004000
-
-(CRZDEMO.ABS):
-000000 01 50 00 03 00 00 00 00 00 03 83 10 00 00 05 3b
-000010 00 1c 00 03 00 00 01 07 00 00 1d d0 00 03 64 98
-000020 00 06 8b 80 00 80 20 00 00 80 20 00 00 80 3d d0
-
-000030 2e 74 78 74 00 00 00 00 00 80 20 00 00 80 20 00 .txt (+36 bytes)
-000040 00 00 1d d0 00 00 00 a8 00 00 00 00 00 00 00 00
-000050 00 00 00 00 00 00 00 20
-000058 2e 64 74 61 00 00 00 00 00 80 3d d0 00 80 3d d0 .dta (+36 bytes)
-000068 00 03 64 98 00 00 1e 78 00 00 00 00 00 00 00 00
-000078 00 00 00 00 00 00 00 40
-000080 2e 62 73 73 00 00 00 00 00 00 50 00 00 00 50 00 .bss (+36 bytes)
-000090 00 06 8b 80 00 03 83 10 00 00 00 00 00 00 00 00
-0000a0 00 00 00 00 00 00 00 80
-
-Header size is $A8 bytes...
-
-BSD/COFF format file detected...
-3 sections specified
-Symbol Table offset = 230160 ($00038310)
-Symbol Table contains 1339 symbol entries ($0000053B)
-The additional header size is 28 bytes ($001C)
-Magic Number for RUN_HDR = 0x00000107
-Text Segment Size = 7632 ($00001DD0)
-Data Segment Size = 222360 ($00036498)
-BSS Segment Size = 428928 ($00068B80)
-Starting Address for executable = 0x00802000
-Start of Text Segment = 0x00802000
-Start of Data Segment = 0x00803dd0
-*/
- if (jaguarMainROM[0] == 0x60 && jaguarMainROM[1] == 0x1B)
- {
- uint32 loadAddress = GET32(jaguarMainROM, 0x16), //runAddress = GET32(jaguar_mainRom, 0x2A),
- codeSize = GET32(jaguarMainROM, 0x02) + GET32(jaguarMainROM, 0x06);
- WriteLog("GUI: Setting up homebrew (ABS-1)... Run address: %08X, length: %08X\n", loadAddress, codeSize);
-
- if (loadAddress < 0x800000)
- memcpy(jaguarMainRAM + loadAddress, jaguarMainROM + 0x24, codeSize);
- else
- {
- for(int i=codeSize-1; i>=0; i--)
- jaguarMainROM[(loadAddress - 0x800000) + i] = jaguarMainROM[i + 0x24];
-/* memcpy(jaguar_mainRam, jaguar_mainRom + 0x24, codeSize);
- memset(jaguar_mainRom, 0xFF, 0x600000);
- memcpy(jaguar_mainRom + (loadAddress - 0x800000), jaguar_mainRam, codeSize);
- memset(jaguar_mainRam, 0x00, 0x400000);*/
- }
-
- jaguarRunAddress = loadAddress;
- }
- else if (jaguarMainROM[0] == 0x01 && jaguarMainROM[1] == 0x50)
- {
- uint32 loadAddress = GET32(jaguarMainROM, 0x28), runAddress = GET32(jaguarMainROM, 0x24),
- codeSize = GET32(jaguarMainROM, 0x18) + GET32(jaguarMainROM, 0x1C);
- WriteLog("GUI: Setting up homebrew (ABS-2)... Run address: %08X, length: %08X\n", runAddress, codeSize);
-
- if (loadAddress < 0x800000)
- memcpy(jaguarMainRAM + loadAddress, jaguarMainROM + 0xA8, codeSize);
- else
- {
- for(int i=codeSize-1; i>=0; i--)
- jaguarMainROM[(loadAddress - 0x800000) + i] = jaguarMainROM[i + 0xA8];
-/* memcpy(jaguar_mainRam, jaguar_mainRom + 0xA8, codeSize);
- memset(jaguar_mainRom, 0xFF, 0x600000);
- memcpy(jaguar_mainRom + (loadAddress - 0x800000), jaguar_mainRam, codeSize);
- memset(jaguar_mainRam, 0x00, 0x400000);*/
- }
-
- jaguarRunAddress = runAddress;
- }
- else
- {
- WriteLog("GUI: Couldn't find correct ABS/COF format: %02X %02X\n", jaguarMainROM[0], jaguarMainROM[1]);
- return false;
- }
- }
- else if (strcasecmp(ext, ".jag") == 0)
- {
- // File extension ".JAG": Atari server file with header
-//NOTE: The bytes 'JAGR' should also be at position $1C...
-// Also, there's *always* a $601A header at position $00...
- if (jaguarMainROM[0] == 0x60 && jaguarMainROM[1] == 0x1A)
- {
- uint32 loadAddress = GET32(jaguarMainROM, 0x22), runAddress = GET32(jaguarMainROM, 0x2A);
-//This is not always right! Especially when converted via bin2jag1!!!
-//We should have access to the length of the furshlumiger file that was loaded anyway!
-//Now, we do! ;-)
-// uint32 progLength = GET32(jaguar_mainRom, 0x02);
-//jaguarRomSize
-//jaguarRunAddress
-// WriteLog("Jaguar: Setting up PD ROM... Run address: %08X, length: %08X\n", runAddress, progLength);
-// memcpy(jaguar_mainRam + loadAddress, jaguar_mainRom + 0x2E, progLength);
- WriteLog("GUI: Setting up homebrew (JAG)... Run address: %08X, length: %08X\n", runAddress, jaguarROMSize - 0x2E);
- memcpy(jaguarMainRAM + loadAddress, jaguarMainROM + 0x2E, jaguarROMSize - 0x2E);
-// SET32(jaguar_mainRam, 4, runAddress);
- jaguarRunAddress = runAddress;
- }
- else
- return false;
- }
- // .J64 (Jaguar cartridge ROM image) is implied by the FileList object...
-
- return true;
-}
//
// Jaguar file loading (second stab at it...)
@@ -331,7 +118,6 @@ bool JaguarLoadFile(char * path)
{
// WriteLog("VJ: Could not load ROM from file \"%s\"...\nAborting!\n", newPath);
WriteLog("GUI: Could not load ROM from file \"%s\"...\nAborting load!\n", path);
-#warning "!!! Need error dialog here !!!"
// Need to do something else here, like throw up an error dialog instead of aborting. !!! FIX !!!
return false; // This is a start...
}
@@ -440,11 +226,13 @@ static int gzfilelength(gzFile gd)
//
// Compare extension to passed in filename. If equal, return true; otherwise false.
//
+/*
static bool CheckExtension(const char * filename, const char * ext)
{
const char * filenameExt = strrchr(filename, '.'); // Get the file's extension (if any)
return (strcasecmp(filenameExt, ext) == 0 ? true : false);
}
+*/
//
// Get file from .ZIP
@@ -454,12 +242,11 @@ static bool CheckExtension(const char * filename, const char * ext)
//
uint32 GetFileFromZIP(const char * zipFile, enum FileType type, uint8_t **buffer)
{
- bool found = false;
+ //bool found = false;
uint32 fileSize = 0;
// NOTE: We could easily check for this by discarding anything that's larger than the RAM/ROM
// size of the Jaguar console.
-#warning "!!! FIX !!! Should have sanity checking for ROM size to prevent buffer overflow!"
#if 0 // TODO - reimplement this
const char ftStrings[5][32] = { "Software", "EEPROM", "Label", "Box Art", "Controller Overlay" };
ZIP * zip = openzip(0, 0, zipFile);
@@ -481,7 +268,6 @@ uint32 GetFileFromZIP(const char * zipFile, enum FileType type, uint8_t **buffer
// Here we simply rely on the file extension to tell the truth, but we know
// that extensions lie like sons-a-bitches. So this is naive, we need to do
// something a little more robust to keep bad things from happening here.
-#warning "!!! Checking for image by extension can be fooled !!!"
if ((type == FT_LABEL) && (CheckExtension(ze->name, ".png") || CheckExtension(ze->name, ".jpg") || CheckExtension(ze->name, ".gif")))
{
found = true;
diff --git a/src/jaguar/gpu.c b/src/jaguar/gpu.c
index 8bb7fb24..b310c6f0 100644
--- a/src/jaguar/gpu.c
+++ b/src/jaguar/gpu.c
@@ -282,7 +282,7 @@ uint8 gpu_opcode_cycles[64] =
1, 1, 1, 1, 1, 1, 1, 1
};//*/
-void (*gpu_opcode[64])()=
+void (*gpu_opcode[64])(void)=
{
gpu_opcode_add, gpu_opcode_addc, gpu_opcode_addq, gpu_opcode_addqt,
gpu_opcode_sub, gpu_opcode_subc, gpu_opcode_subq, gpu_opcode_subqt,
@@ -394,7 +394,7 @@ uint32 GPUGetPC(void)
return gpu_pc;
}
-void build_branch_condition_table(void)
+static void build_branch_condition_table(void)
{
if (!branch_condition_table)
{
@@ -804,7 +804,7 @@ WriteLog("\n");
}
}//*/
extern int effect_start5;
-static bool finished = false;
+//static bool finished = false;
//if (GPU_RUNNING && effect_start5 && !finished)
if (GPU_RUNNING && effect_start5 && gpu_pc == 0xF035D8)
{
@@ -1113,8 +1113,8 @@ void GPUDone(void)
//
// Main GPU execution core
//
-static int testCount = 1;
-static int len = 0;
+//static int testCount = 1;
+//static int len = 0;
static bool tripwire = false;
void GPUExec(int32 cycles)
{
diff --git a/src/jaguar/jagdasm.c b/src/jaguar/jagdasm.c
index 8b1246c0..6d7395e1 100644
--- a/src/jaguar/jagdasm.c
+++ b/src/jaguar/jagdasm.c
@@ -46,10 +46,9 @@ const char * condition[32] =
"???,",
"never,"
};
-
-char * signed_16bit(int16 val)
+static char * signed_16bit(int16 val)
{
static char temp[10];
@@ -61,13 +60,14 @@ char * signed_16bit(int16 val)
return temp;
}
-unsigned dasmjag(int dsp_type, char * buffer, unsigned pc)
+unsigned dasmjag(int dsp_type, char *dest, unsigned pc)
{
int op = ROPCODE(pc);
int reg1 = (op >> 5) & 31;
int reg2 = op & 31;
int size = 2;
-
+ char buffer[512];
+
pc += 2;
switch (op >> 10)
{
@@ -160,7 +160,7 @@ unsigned dasmjag(int dsp_type, char * buffer, unsigned pc)
sprintf(buffer, "ADDQMOD $%X,R%02d", convert_zero[reg1], reg2);
break;
}
- sprintf(buffer,"%-24s (%04X)", buffer, op);
+ sprintf(dest,"%-24s (%04X)", buffer, op);
return size;
}
diff --git a/src/jaguar/jaguar.c b/src/jaguar/jaguar.c
index 82c9f5d9..5a12d059 100644
--- a/src/jaguar/jaguar.c
+++ b/src/jaguar/jaguar.c
@@ -24,6 +24,7 @@
#include "dsp.h"
#include "eeprom.h"
#include "event.h"
+#include "file.h"
#include "gpu.h"
#include "jerry.h"
#include "joystick.h"
@@ -83,6 +84,8 @@ uint32 pcQPtr = 0;
//
void GPUDumpDisassembly(void);
void GPUDumpRegisters(void);
+
+#if 0
static bool start = false;
void M68KInstructionHook(void)
@@ -348,8 +351,10 @@ CD_switch:: -> $306C
}//*/
#endif
}
+#endif
#if 0
+/*
Now here be dragons...
Here is how memory ranges are defined in the CoJag driver.
Note that we only have to be concerned with 3 entities read/writing anything:
@@ -360,6 +365,7 @@ this crap which is currently scattered over Hell's Half Acre(tm).
Also: We need to distinguish whether or not we need .b, .w, and .dw versions of everything, or if there
is a good way to collapse that shit (look below for inspiration). Current method works, but is error prone.
+*/
/*************************************
*
@@ -1085,7 +1091,7 @@ if (address == 0xF03214 && value == 0x88E30047)
}
-uint32 JaguarGetHandler(uint32 i)
+static uint32_t JaguarGetHandler(uint32_t i)
{
return JaguarReadLong(i * 4, UNKNOWN);
}
diff --git a/src/jaguar/jerry.c b/src/jaguar/jerry.c
index 671b08af..e1a447bf 100644
--- a/src/jaguar/jerry.c
+++ b/src/jaguar/jerry.c
@@ -207,7 +207,7 @@ void JERRYI2SCallback(void);
void JERRYI2SExec(uint32 cycles)
{
#ifndef NEW_TIMER_SYSTEM
-#warning "externed var in source--should be in header file. !!! FIX !!!"
+ // TODO: externed var in source--should be in header file. !!! FIX !!!
extern uint16 serialMode; // From DAC.CPP
if (serialMode & 0x01) // INTERNAL flag (JERRY is master)
{
@@ -364,8 +364,7 @@ void JERRYPIT2Callback(void)
void JERRYI2SCallback(void)
{
// Why is it called this? Instead of SCLK? Shouldn't this be read from DAC.CPP???
-//Yes, it should. !!! FIX !!!
-#warning "Why is it called this? Instead of SCLK? Shouldn't this be read from DAC.CPP??? Yes, it should. !!! FIX !!!"
+ // Yes, it should. !!! FIX !!!
JERRYI2SInterruptDivide &= 0xFF;
// We don't have to divide the RISC clock rate by this--the reason is a bit
// convoluted. Will put explanation here later...
diff --git a/src/jaguar/m68k.h b/src/jaguar/m68k.h
index b9bc8f4b..9cfa95e3 100644
--- a/src/jaguar/m68k.h
+++ b/src/jaguar/m68k.h
@@ -15,6 +15,7 @@
#include "../cpu/disasm.h"
#include "../cpu/options_cpu.h"
#include "../cpu/hatari-glue.h"
+#include "../includes/main.h"
#include "../includes/m68000.h"
#include "../includes/configuration.h"
diff --git a/src/jaguar/objectp.c b/src/jaguar/objectp.c
index d6a5c724..0ca9a631 100644
--- a/src/jaguar/objectp.c
+++ b/src/jaguar/objectp.c
@@ -256,7 +256,7 @@ uint64 OPLoadPhrase(uint32 offset)
return ((uint64)JaguarReadLong(offset, OP) << 32) | (uint64)JaguarReadLong(offset+4, OP);
}
-void OPStorePhrase(uint32 offset, uint64 p)
+static void OPStorePhrase(uint32 offset, uint64 p)
{
offset &= ~0x07; // 8 byte alignment
JaguarWriteLong(offset, p >> 32, OP);
@@ -275,7 +275,7 @@ void DumpScaledObject(uint64 p0, uint64 p1, uint64 p2)
//WAS: int16 ypos = ((p0 >> 3) & 0x3FF); // ??? What if not interlaced (/2)?
int16 ypos = ((p0 >> 3) & 0x7FF); // ??? What if not interlaced (/2)?
int32 xpos = p1 & 0xFFF;
- xpos = (xpos & 0x800 ? xpos | 0xFFFFF000 : xpos);
+ xpos = (xpos & 0x800 ? xpos | (int32_t)0xFFFFF000 : xpos);
uint32 iwidth = ((p1 >> 28) & 0x3FF);
uint32 dwidth = ((p1 >> 18) & 0x3FF); // Unsigned!
uint16 height = ((p0 >> 14) & 0x3FF);
@@ -301,7 +301,7 @@ void DumpFixedObject(uint64 p0, uint64 p1)
//WAS: int16 ypos = ((p0 >> 3) & 0x3FF); // ??? What if not interlaced (/2)?
int16 ypos = ((p0 >> 3) & 0x7FF); // ??? What if not interlaced (/2)?
int32 xpos = p1 & 0xFFF;
- xpos = (xpos & 0x800 ? xpos | 0xFFFFF000 : xpos);
+ xpos = (xpos & 0x800 ? xpos | (int32_t)0xFFFFF000 : xpos);
uint32 iwidth = ((p1 >> 28) & 0x3FF);
uint32 dwidth = ((p1 >> 18) & 0x3FF); // Unsigned!
uint16 height = ((p0 >> 14) & 0x3FF);
@@ -320,7 +320,6 @@ void DumpFixedObject(uint64 p0, uint64 p1)
//
//Need to fix this so that when an GPU object IRQ happens, we can pick up OP processing
//where we left off. !!! FIX !!!
-#warning "Need to fix this so that when an GPU object IRQ happens, we can pick up OP processing where we left off. !!! FIX !!!"
void OPProcessList(int scanline, bool render)
{
extern int op_start_log;
@@ -372,8 +371,8 @@ WriteLog("\n%08X --> phrase %08X %08X ", op_pointer, (int)(p1>>32), (int)(p1&0xF
uint8 bitdepth = (p1 >> 12) & 0x07;
//WAS: int16 ypos = ((p0 >> 3) & 0x3FF); // ??? What if not interlaced (/2)?
int16 ypos = ((p0 >> 3) & 0x7FF); // ??? What if not interlaced (/2)?
-int32 xpos = p1 & 0xFFF;
-xpos = (xpos & 0x800 ? xpos | 0xFFFFF000 : xpos);
+ int32_t xpos = p1 & 0xFFF;
+ xpos = (xpos & 0x800 ? xpos | (int32_t)0xFFFFF000 : xpos);
uint32 iwidth = ((p1 >> 28) & 0x3FF);
uint32 dwidth = ((p1 >> 18) & 0x3FF); // Unsigned!
uint16 height = ((p0 >> 14) & 0x3FF);
@@ -395,8 +394,8 @@ WriteLog("\n%08X --> phrase %08X %08X ", op_pointer+8, (int)(p2>>32), (int)(p2&0
uint8 bitdepth = (p1 >> 12) & 0x07;
//WAS: int16 ypos = ((p0 >> 3) & 0x3FF); // ??? What if not interlaced (/2)?
int16 ypos = ((p0 >> 3) & 0x7FF); // ??? What if not interlaced (/2)?
-int32 xpos = p1 & 0xFFF;
-xpos = (xpos & 0x800 ? xpos | 0xFFFFF000 : xpos);
+ int32_t xpos = p1 & 0xFFF;
+ xpos = (xpos & 0x800 ? xpos | (int32_t)0xFFFFF000 : xpos);
uint32 iwidth = ((p1 >> 28) & 0x3FF);
uint32 dwidth = ((p1 >> 18) & 0x3FF); // Unsigned!
uint16 height = ((p0 >> 14) & 0x3FF);
@@ -626,7 +625,7 @@ OP: Scaled bitmap 4x? 4bpp at 34,? hscale=80 fpix=0 data=000756E8 pitch 1 hflipp
case OBJECT_TYPE_GPU:
{
//WriteLog("OP: Asserting GPU IRQ #3...\n");
-#warning "Need to fix OP GPU IRQ handling! !!! FIX !!!"
+ // TODO: Need to fix OP GPU IRQ handling! !!! FIX !!!
OPSetCurrentObject(p0);
GPUSetIRQLine(3, ASSERT_LINE);
//Also, OP processing is suspended from this point until OBF (F00026) is written to...
@@ -666,7 +665,7 @@ OP: Scaled bitmap 4x? 4bpp at 34,? hscale=80 fpix=0 data=000756E8 pitch 1 hflipp
break;
case CONDITION_SECOND_HALF_LINE:
// This basically means branch if bit 10 of HC is set
-#warning "Unhandled condition code causes emulator to crash... !!! FIX !!!"
+ // TODO: Unhandled condition code causes emulator to crash... !!! FIX !!!
WriteLog("OP: Unexpected CONDITION_SECOND_HALF_LINE in BRANCH object\nOP: shuting down\n");
LogDone();
exit(0);
@@ -703,7 +702,6 @@ OP: Scaled bitmap 4x? 4bpp at 34,? hscale=80 fpix=0 data=000756E8 pitch 1 hflipp
// Here is a little sanity check to keep the OP from locking up the machine
// when fed bad data. Better would be to count how many actual cycles it used
// and bail out/reenter to properly simulate an overloaded OP... !!! FIX !!!
-#warning "Better would be to count how many actual cycles it used and bail out/reenter to properly simulate an overloaded OP... !!! FIX !!!"
opCyclesToRun--;
if (!opCyclesToRun)
return;
@@ -829,8 +827,8 @@ void OPProcessFixedBitmap(uint64 p0, uint64 p1, bool render)
// rightMargin = lbufWidth + (clippedWidth % phraseWidthToPixels[depth]);
// rightMargin = lbufWidth;
*/
-if (depth > 5)
- WriteLog("OP: We're about to encounter a divide by zero error!\n");
+ if (depth > 5)
+ WriteLog("OP: We're about to encounter a divide by zero error!\n");
// NOTE: We're just using endPos to figure out how much, if any, to clip by.
// ALSO: There may be another case where we start out of bounds and end out of bounds...!
// !!! FIX !!!
diff --git a/src/jaguar/tom.c b/src/jaguar/tom.c
index de7a3792..a1a70d23 100644
--- a/src/jaguar/tom.c
+++ b/src/jaguar/tom.c
@@ -534,8 +534,8 @@ uint32 RGB16ToRGB32[0x10000];
uint32 CRY16ToRGB32[0x10000];
uint32 MIX16ToRGB32[0x10000];
-#warning "This is not endian-safe. !!! FIX !!!"
-void TOMFillLookupTables(void)
+// TODO: This is not endian-safe. !!! FIX !!!
+static void TOMFillLookupTables(void)
{
// NOTE: Jaguar 16-bit (non-CRY) color is RBG 556 like so:
// RRRR RBBB BBGG GGGG
@@ -596,7 +596,6 @@ uint8 TOMGetVideoMode(void)
}
//Used in only one place (and for debug purposes): OBJECTP.CPP
-#warning "Used in only one place (and for debug purposes): OBJECTP.CPP !!! FIX !!!"
uint16 TOMGetVDB(void)
{
return GET16(tomRam8, VDB);
@@ -794,7 +793,6 @@ void TOMExecScanline(uint16 scanline, bool render)
if (inActiveDisplayArea)
{
//NOTE: The following doesn't put BORDER color on the sides... !!! FIX !!!
-#warning "The following doesn't put BORDER color on the sides... !!! FIX !!!"
if (vjs.renderType == RT_NORMAL)
scanline_render[TOMGetVideoMode()](TOMBackbuffer);
else//TV type render
@@ -812,9 +810,11 @@ void TOMExecScanline(uint16 scanline, bool render)
#define MODE 0x0006 // Line buffer to video generator mode
#define VARMOD 0x0100 // Mixed CRY/RGB16 mode (only works in MODE 0!)
*/
+ /*
uint8 pwidth = ((GET16(tomRam8, VMODE) & PWIDTH) >> 9) + 1;
uint8 mode = ((GET16(tomRam8, VMODE) & MODE) >> 1);
bool varmod = GET16(tomRam8, VMODE) & VARMOD;
+ */
//The video texture line buffer ranges from 0 to 1279, with its left edge starting at
//LEFT_VISIBLE_HC. So, we need to start writing into the backbuffer at HDB1, using pwidth
//as our scaling factor. The way it generates its image on a real TV!
@@ -836,7 +836,7 @@ void TOMExecScanline(uint16 scanline, bool render)
*currentLineBuffer++ = pixel;
}
-#warning "!!! Need to move this to an interface file !!! FIX !!!"
+ // TODO: !!! Need to move this to an interface file !!! FIX !!!
// TOMBackbuffer += GetSDLScreenWidthInPixels();
TOMBackbuffer += tomDeviceWidth;
}
@@ -1065,8 +1065,8 @@ uint16 TOMReadWord(uint32 offset, uint32 who/*=UNKNOWN*/)
#ifdef TOM_DEBUG
WriteLog("TOM: Reading word at %06X\n", offset);
#endif
-if (offset >= 0xF02000 && offset <= 0xF020FF)
- WriteLog("TOM: Read attempted from GPU register file by %s (unimplemented)!\n", whoName[who]);
+ if (offset >= 0xF02000 && offset <= 0xF020FF)
+ WriteLog("TOM: Read attempted from GPU register file by %s (unimplemented)!\n", whoName[who]);
if (offset == 0xF000E0)
{
@@ -1259,8 +1259,7 @@ void TOMWriteWord(uint32 offset, uint16 data, uint32 who/*=UNKNOWN*/)
offset &= 0x3FFF;
if (offset == 0x28) // VMODE (Why? Why not OBF?)
-//Actually, we should check to see if the Enable bit of VMODE is set before doing this... !!! FIX !!!
-#warning "Actually, we should check to see if the Enable bit of VMODE is set before doing this... !!! FIX !!!"
+ // Actually, we should check to see if the Enable bit of VMODE is set before doing this... !!! FIX !!!
objectp_running = 1;
if (offset >= 0x30 && offset <= 0x4E)
--
2.48.1
--MP_/VkVZp1l8MIESxWVe2vPSxV2
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=0020-Silence-compiler-warnings-reported-by-Clang.patch