| Re: [hatari-devel] SCSI Driver improvements patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] SCSI Driver improvements patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Sun, 12 Jan 2025 16:28:12 +0100
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1736695709; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=dgQ1yAo+EfEGrJVrJJNACMoAiVK1613z4IM3eYGGnU0=; b=Lejd7vMmeW9JXCkhzARUEMNRPRlzL1swxTHtP33rMlr4LUZX+kwFomu9DSwEn6eC3J KLBsHSlyiy3x0K1lK6jEwjuLEU/RE/qzP8XbJ5D/Wm7DilO/9RsLMZ/j2ui3NL3fHYmr GuFM1ZCK5N0odL29Iskv/ivv/29xrGaPsQHa3iShaoEfZbvmusfFy9IcTOVzm1H0rXdR 3b1cFMqQgX7iKaE7kTECOWRQ3MdCaNpKpCpfXbAwrES2QPx/dMLuat+wEKgMGRPxxQsu BmZI/hOAU9yY1MktHH2QQ22JHzZg8qvyLFQ4cXUy2UqGixlX/QnGBsO4XkAn6KHMCg38 mSOA==
- Arc-seal: i=1; a=rsa-sha256; t=1736695709; cv=none; d=strato.com; s=strato-dkim-0002; b=e+FmfEYS708synP3QE5eBqP0OH92Rhv9Fw7W39D4kJ2bQbhk4au2cm2k/BcmhaEPsn OgjbOyxDJrVJXax7+PjKW8AgngoIxci4KrrAJDKG+gI5Ii8VbKG3ZKc/xvMNoUJ7TKJU nJ27gsiPaWP26hVznSbs1AoapD+khX3tZJdqvGptXfHvA++HSIK8gfmR+0y51ItvqmaW rD2C6bnrZ0uxMqGyOpDFygTzOoW1UlbHK2hKeUdYmbukc55IcPU2EStRwPz1Q73zbx21 5GyzooHp+BFxu0m6BYS1r4A1GpInUM07piIW2MI7gZ0lsXhaCSiWwQ+APNMMlPK9JhLk 9v6w==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1736695709; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=dgQ1yAo+EfEGrJVrJJNACMoAiVK1613z4IM3eYGGnU0=; b=DakD723MayoOoQwZPHs0TiLxZ34ZqIr1rwAetmVzLMCe3L/q8l+dtedY7igAQijsC1 pBM1swHO1J5hZUMLSIgCpFrtuSMB0CRmbBErfBv6+1KWWkUuiBCRGbiozPaDVIBfVHEt frEX3VEWX1QblsykIBLkboYOSKCQ5Hc4ooTG04SYvdCWnitnOLAQOjAEWGC+nG/ISIaD C2XuZfhUGwHhn/OudbbUKMYpJs4VG7M4bixhlHlE0zxsJ0RN6tGG8ohk/8zFLbWL4web 5LY74+LonsCP4lHrD3X/JGlQlZAjmh0ynoM//tG3sp66aPCM6XCZTHMt4tA+a3rlWPMd AVvw==
- Dkim-signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1736695709; s=strato-dkim-0003; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=dgQ1yAo+EfEGrJVrJJNACMoAiVK1613z4IM3eYGGnU0=; b=3NH9hiq3xqB6rmD0rnGWc2t2va33jmc8UNWVRNMhPAT+TJlqXk3nxtzv8Ifz8nzSmD dNAHu4yF2JEVBRdCg/BQ==
Hi,
> * read_stack_pointer(): calls STMemory_STAddrToPointer(), but does not
> check that the addresses are valid, as it should:
Wouldn't it be better if Hatari was checking this in
STMemory_STAddrToPointer(), at least optionally? The existing conversions
between native and Atari address space already make the code in nf_scsidrv.c
(and likely elsewhere) hard to read. I don't doubt that these checks are
useful, but I wonder whether there are better solutions than explicit checks
everywhere.
Best regards
Uwe