| Re: [hatari-devel] SCSI Driver improvements patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] SCSI Driver improvements patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Fri, 13 Dec 2024 11:16:27 +0100
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1734084991; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=x/zZmWMxeVb9WQbDxcypxJDdnbtfjqVz76PqGTY//6A=; b=q7Ruw+pEpYZOVw22WWArtsfkr/p3gETgPbvbxTxyKR8167fp47Op9mTnIkLldYi3AE o1csbpXuWf2KqUjb6opWHTyvo5CiQq0L85ThcT2GkX6w5tSVDlaRFqS4cU4KhSOMQ1/S oUUC3nTCSTB8btpd9bv2Bf/sjX1MWL7OoMPGQFYljBXFy3vRnWoxKzsWTabKhdKWwZn/ mfswFMp7XYc1Fr/8kSCdgEwivZBEv3o7wFsy5xK4XSeKdakq8s8vqrUkBUyghSvkU7FB qbiriwQpxxerWFHks+Cu/faELX+fcYIxN2xHatGlYOhKUqMzGKFg67KMbCq1RPev6Vrh H4Xg==
- Arc-seal: i=1; a=rsa-sha256; t=1734084991; cv=none; d=strato.com; s=strato-dkim-0002; b=ZOM8wWt/6bZdt4dfLyrcqwT8u760WOtkMiHQCCjyKvoyC7BIop7rz+h2e+JChezftI nr5oOMiR8pDYo8s7uXkBk5g7ASvbqyHdtxOyXTImSZIUr3p06CAUKgn0CrPQJBaA2uMT 1iwTFdJ3z//StZGpKsH5095mKV70cZHrYMRFYLApxJLzpiW4RwZ/ZSsJP59/pZ7dYU6Y F6VOwbqmQm0qQCbYqXzwvw9bGceExv6a3TL+8EePaFc7ssVuAufl6XdqubVVpDX0iJen LoqOetdvDUD3cQbnW78dvyU7/RMKqsjT2UBXVK3jGO5SiOend6yh2NbasWHPcbLnHWJh LOtw==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1734084991; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=x/zZmWMxeVb9WQbDxcypxJDdnbtfjqVz76PqGTY//6A=; b=MysXlRk0vTSEMnav+l0437buXXrf7txL5r7e4D9vwFKNql1V6GCzAE3shWs5nOlJAB fPKmZOEN97utd2Bz3AnKmKXNgQJ9Fxgl94NOLO2Us6Ba5tcv7cIIKsdQFux4o3uho5F0 c2I50Sl/k2pC5Cvci+zFIbCz72vAgHrECYJKfznVfqFNNiF9a4eXU6MdV4sJM7LYrOwA 286PsUUA607CNUcLy8s5XYVoomkI5JTRwz3e+mOFqUOIKcrU8FL5eIpBfXc9gdoHpe2C urlGafJ2+5zQMx9LLcuXYgfYEWu6iKXu0OqyGSwESBf4bhO2xZF9MSGYgks4k0UMPIEE T1dQ==
- Dkim-signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1734084991; s=strato-dkim-0003; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=x/zZmWMxeVb9WQbDxcypxJDdnbtfjqVz76PqGTY//6A=; b=9+Sjh3W/+1gzFxaQSE6r+M1Jms8ArRNrxzaQJbkSBN3b1dMN420YatomkUNxQIbNgr FIDgCj9xwxjkuuyWpYDQ==
Hi,
Thank you for merging. I will look at the other changes later.
Best regards
Uwe
> I pushed it as-is (so that you can do pull without conflicts), but while
> reviewing the changes and earlier nf_scsidrv.c code, I noticed few
> security / reliability bugs, that you would need to fix with additional
> patch.
>
> Namely:
> * read_stack_pointer(): calls STMemory_STAddrToPointer(), but does not
> check that the addresses are valid, as it should:
> https://git.tuxfamily.org/hatari/hatari.git/tree/src/stMemory.c#n554
> * scsidrv_interface_features(): does long/word writes to addresses taken
> for emulator stack, but does not check that (also) those addresses are
> within emulated memory
> * scsidrv_inout(): memcpy()s & writes to "sense_buffer" address taken
> from emulated stack, but does not check validity of that address area
>
>
> > The Hatari git is often very slow. "git pull" often takes several minutes
> > or just hangs.
>
> It can hang if the tuxfamily.org is down, but that's been very rare, at
> last until recently. Otherwise git has been fairly responsive for me.
>
>
> - Eero
>
>
>