Re: [hatari-devel] Hatari GEMDOS drive volume name

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 08/09/2024 à 15:50, Eero Tamminen a écrit :
> Hi Uwe,
>
> On 8.9.2024 11.45, Uwe Seimet wrote:
> > if(!Fsfirst("C:\*.*", FA_VOLUME)) {
> >    DTA *dta = Fgetdta();
> >
> >    if(dta->d_attrib == 0x08) {
> >      // Unexpected: d_attrib is $00 here, shouldn't it be 0x08?
> >      // d_fname is "EMULATED.002"
> >    }
> > }
>
> Thanks for reporting!
>
> Fix for that is one-liner, but the attached patch should fix also few 
> other GEMDOS HD attribute handling corner-cases I noticed while 
> investigating this.
>
> => It's good if you could test that it does not regress anything else 
> before I commit it.
>
> (Hatari GEMDOS HD unit test are very basic, as is my setup & manual 
> testing, so you're likely to catch things I do not.)
>
>
> Thomas / Nicolas, does the patch look OK?

Hi

I'm afraid I'm not very aware of the inner work of gemdos.c so I can't 
tell if the patch is OK or not :(  (apart from the fact that Uwe told 
this fixed his case)



Nicolas