Re: [hatari-devel] Esc key appears to be pressed, but is not

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Tue, 3 Sep 2024 16:55:30 +0200
schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:

> After having this patch enabled for some time, I disabled it and again have
> been using Hatari for some time.
> All in all I did not notice a difference, at least my impression is that
> with the patch the problem occurs as often as it does without it.

Ok. Then I wonder whether we rather should maybe disable automatic mouse
reporting until TOS explicitly enables the relative mouse mode via
IKBD_Cmd_RelMouseMode() ... Nicolas, what do you think?

 Thomas


> > Am Sun, 18 Aug 2024 09:16:22 +0200
> > schrieb Christian Zietz <czietz@xxxxxxx>:
> >   
> > > Uwe Seimet schrieb:
> > >   
> > > > Maybe somebody else also stumbles upon it in a
> > > > scenario where it can be better reproduced.    
> > > 
> > > FWIW, I get a similar "key stuck" error if I boot Hatari (commit
> > > f86d067) into TOS 2.06 and start violently moving the mouse over the
> > > Hatari window right after start, i.e., before even the Atari logo
> > > appears. I don't have time to bisect this, though.  
> > 
> > I can reproduce that one, too. And actually, this already occurred with
> > other TOS versions in the past and Hatari has already a work-around
> > included for it (by not sending mouse movements within the first 10 VBLs).
> > Looks like 10 VBLs are not enough for TOS 2.06, but increasing it to 40
> > VBLs fixes the problem here, too:
> > 
> > diff --git a/src/main.c b/src/main.c
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -504,7 +504,7 @@ static void Main_HandleMouseMotion(int dx, int dy)
> >  
> >         /* Ignore motion when position has changed right after a reset or TOS
> >          * (especially version 4.04) might get confused and play key clicks */
> > -       if (bIgnoreNextMouseMotion || nVBLs < 10)
> > +       if (bIgnoreNextMouseMotion || nVBLs < 40)
> >         {
> >                 bIgnoreNextMouseMotion = false;
> >                 return;
> > 
> > Uwe, could you please check whether that patch helps with your problem, too?
> > 
> >  Thomas
> > 
> >   
> 
>