Re: [hatari-devel] windows build failing on cirrus-ci

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Nicolas Pomarède schrieb:

Yes, the problem is in the new function "loadSymFile"

I don't know if this is supported in a more recent version of visual C
than the one used in cirrus-ci,

I am always very cautions about variable length arrays, anyway. Like any local variable, they are allocated on the stack; but with a VLA one can only cross one's fingers to hope that it fits without causing a stack exhaustion.

See https://wiki.sei.cmu.edu/confluence/display/c/ARR32-C.+Ensure+size+arguments+for+variable+length+arrays+are+in+a+valid+range

... which incidentally also happens to mention: "Variable length arrays are not supported by Microsoft compilers." This is confirmed by https://learn.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version?view=msvc-170: "Variable length array (VLA) support isn't planned. VLAs provide attack vectors [...]".

Regards
Christian
--
Christian Zietz  -  CHZ-Soft  -  czietz@xxxxxxx
WWW: https://www.chzsoft.de/
New GnuPG-Key-ID: 0x8708B34C827B159E



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/