Re: [hatari-devel] Separate --cpu-caches option

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Le 21/04/2024 à 23:39, Eero Tamminen a écrit :
Hi,

On 17.3.2024 11.30, Nicolas Pomarède wrote:
Le 16/03/2024 à 23:53, Eero Tamminen a écrit :
As WinUAE CPU core supports it, attached is patch to enable CPU caches separately from cycle exact and prefetch/compatible options.

It should help in identifying compatibility issues better, and having more control over Hatari performance.
...
I think variable should be bCpuCacheData instead of just bCpuCaches because it's not the same thing as the instruction cache.

Ok. I changed it to --data-cache / bCpuDataCache option (after checking WinUAE CPU core code).  New version attached.


Also, doing just a true/false that removes  the whole other tests in m68000.c is not good, because it can leave cache=true for 68000 cpu and have side effect later. so it should be something like :

         if ( ( changed_prefs.cpu_model < 68020 )
          ||  ( ( changed_prefs.cpu_compatible == false ) && ( changed_prefs.cpu_cycle_exact == false ) )
          || ( ConfigureParams.System.bCpuCaches == false )
  )
                 changed_prefs.cpu_data_cache = false;
         else
                 changed_prefs.cpu_data_cache = true;

But this check I changed to be against 030 as 020 does not have d-cache, only i-cache.

Hi
both changes look fine to me

Nicolas




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/