| Re: [hatari-devel] DSP patch suggestion |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] DSP patch suggestion
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Thu, 14 Dec 2023 19:07:59 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1702577299; bh=AwuOk8LP6xgSElfnEY8S709ibc35ua6bE4k8ENZRCdU=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=VoCE5IBloSjn0A5nv29uyYkqnjxlMfQqSuKR/scacMLEKpfWQs044LSWyTL1TBV2C Q4KSMd9KOeTetco/v1nU/uJde4c+1KXSC3+C+7I1Q5qKHPvi3ef96IJz+CKG7L0eoo In9LJODo5CV7Us18uUqhi7wVvYOCLvs+q2S2Dh6O2i8tySDYKOVWykfH4qhMyG9CPk DrPksPvHHas5g5YVUB/nFrueRjarGNTy86Uj8e61n5nrXGtPxrEzVGEqfBANQMgkrO lKExrR9kixlIorFoaE3+v2SNuEJJ95YnmbDYtuacyVb9JNX07dx96YFVWguLJOoOvZ 3u3ykVfRxRgAw==
> Am 14.12.2023 um 11:04 schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
>
> Le 10/12/2023 à 22:49, Andreas Grabher a écrit :
>
>> May I suggest another patch?
>> The appended patch removes some constants that are kind of duplicate. It also makes readout of access_to_ext_memory a bit more safe (in case someone changes to values of the constants).
>> Furthermore it cleans access_to_ext_memory handling a bit. This might be slightly slower (1 << variable instead of 1 << constant) but saves quite some code. On the other hand it replaces "address += DSP_RAMSIZE>>1" with "address |= DSP_RAMSIZE>>1" which might be a bit faster unless the compiler already detected the optimisation potential (and makes more sense when thinking about what real hardware does).
>> You might want to apply the whole patch or parts of it.
>
> Hi
>
> looking at the patch, I don't think it will have a noticeable impact on performance, I applied the whole of it.
>
> Nicolas
>
Thank you for the message. I also think the impact on performance is minimal to zero.