Re: [hatari-devel] hatari.app from cirrus-ci (was: Re: One scanline short in ST fullscreen)

[Andreas Grabher <andreas_g86@xxxxxxxxxx>]

> Am 09.12.2023 um 17:21 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> 
> Am Sat, 9 Dec 2023 14:38:27 +0100
> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> 
>>>> Am 09.12.2023 um 13:51 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
>>> 
>>> Am Thu, 26 Oct 2023 22:15:11 +0200
>>> schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
>>> 
>>>>> Am 26.10.2023 um 20:36 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
>>>>> 
>>>>> Am Tue, 24 Oct 2023 19:53:43 +0000
>>>>> schrieb Anders Eriksson <evldhs@xxxxxxxxxxxxxx>:
>>>>> ...    
>>>>>> Hello again Thomas,
>>>>>> 
>>>>>> I noticed today that the builds from cirrus-ci are missing libpng so compressed videos/screenshots are not possible. 
>>>>>> Not a big deal for screenshots but videos gets very very large.
>>>>>> 
>>>>>> Is it possible to add libpng to these Hatari builds?    
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> main problem is that there does not seem to be a proper pre-built libpng
>>>>> available for macOS. It's likely possible to compile that in the cirrus-CI,
>>>>> too ... but for me that's very cumbersome to come up with the right
>>>>> commands since I don't have a macOS machine for testing, i.e. I have to
>>>>> update the cirrus-ci.yml file by guessing, then submit a built, then wait
>>>>> for the job to get scheduled, then finally find out that I had a typo
>>>>> somewhere, then start again from the beginning ... It would really be
>>>>> better if one of the macOS users could come up with a proper patch for the
>>>>> .cirrus-ci.yml file instead.
>>>>> 
>>>>> Thomas
>>>>> 
>>>>> 
>>>> 
>>>> I appended a pre-built framework version of the latest libpng (1.6.40). It works with macOS 10.13 and later. I have built it with these steps:
>>>> 
>>>>  a Download source code from http://libpng.org/pub/png/libpng.html
>>>>  b Go to the source directory and build an Xcode project:
>>>>       cmake -G Xcode . -DPNG_FRAMEWORK=ON -DPNG_HARDWARE_OPTIMIZATIONS=OFF  
>>> 
>>> Thanks for the instructions, Andreas. I had some spare minutes this morning
>>> and tried to add something similar to the cirrus-ci script:
>>> 
>>> https://github.com/huth/hatari/commit/2ae8f3b050ec9f5e
>>> 
>>> (I think it's likely better to build it in the CI job, too, instead of
>>> downloading a pre-built framework, to make sure that the Xcode version
>>> really matches the one that is used for the Hatari build)
>>> 
>>> Anders, could you please try whether this build works for you:
>>> 
>>> https://cirrus-ci.com/task/5666953684058112
>>> 
>>> If that works fine, I'll add the commit to the main repo.
>>> 
>>> Thomas
>>> 
>> 
>> Hello Thomas,
>> 
>> I just tested it and there seem to be some code signing issues. I had to apply these two commands to make it run:
>> 
>> xattr -cr ~/Downloads/hatari-snapshot/hatari.app
> 
> That's the apple quarantine stuff, I assume? ... I guess there's not much
> that can be done to improve that situation...
> 
>> codesign --force -s - ~/Downloads/hatari-snapshot/hatari.app
> 
> And that's weird, I've already got such a codesign line in the
> cirrus-ci.yml script, not clue why you have to do that again...
> Could some macOS guru please double check whether that stuff in the
> .cirrus-ci.yml file looks right?
> 
> Thomas
> 
I agree that the quarantine and signing stuff of the latest macOS versions is extremely annoying! Your codesign line is different from mine. Probably use the same command as me?