Re: [hatari-devel] Enhanced keymap support

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 10.9.2023 9.32, Thomas Huth wrote:
> since you already started looking into improving the keymap code, could you
> please have a look at this patch series?

It's basically my patch series, with rebase & further improvements done 
by Yves.

Yves has been maintaining it as it supports things that he needs, that 
are not supported by current Hatari keyboard handling [1].

However... This whole thing is my rewrite based on ideas in Vincent 
Barilliot's patch (because he's version wasn't backwards compatible), 
and while it offers useful additional functionality [1], I'm not 
convinced it's the right approach, because:

1) Like Vincent's version, it changes keys to be indexed internally by 
SDL keycode, instead of Atari keycode, and it was triggering 
occasionally some asserts I had added (that are not in Yves series).

2) I'd rather have things working right out of the box, rather than 
users needing (make or install) extra keyboard config files.

Eventually I started thinking that improving symbolic keymapping to 
match Atari side keyboard layout, would be better alternative for 
solving issues with Hatari's current keyboard support.

However, that thing had taken so long to get working well enough, that 
I'd burned out of it. So I'm pretty happy that Brad is looking into 
symbolic keymappings now.


	- Eero

[1] multi-key mappings and Alt-XXX support

> Am Fri, 1 Sep 2023 14:34:07 +0200
> schrieb Yves Le Berre <yves.le_berre@xxxxxxxxx>:
>
> > Hello,
> >
> > Following last keymap.c patches (applied on 2023-08-27) and in
> > case anyone still wants to use enhanced keymap patches serie,
> > I rebased it, renumbered useful and suppressed useless patches.
> >
> > Serie is now :
> >
> > 0001-Keymap_LoadRemapFile-refactor-rewrite.patch
> > 0002-Switch-to-using-KeyMapping-struct-and-KeysDown-array.patch
> > 0003-Clear-KeysDown-key-mapping-state-on-reset.patch
> > 0004-Add-defines-for-some-of-the-ST-scancode-values.patch
> > 0005-Support-for-specifying-ST-key-modifiers-in-the-mappi.patch
> > 0006-Add-ALT-XXX-sequence-insert-support-for-keymaps.patch
> > 0007-Add-trace-output-for-ST-key-modifiers.patch
> > 0008-Support-for-specifying-PC-SDL-key-modifiers-in-the-m.patch
> > 0009-Keymap-accept-also-0x-prefixed-hex-values-for-scanco.patch
> > 0010-Fix-improve-keymap-file-SDL-key-name-parsing.patch
> > 0011-Fix-ALT_XXX-scancode-handling.patch
> > 0012-Fix-Single-Mod-Host-Parsing.patch
> > 0013-Remap-mod.patch
> > 0014-Add-NO-XXX-mod.patch
> > 0015-Replace-strlcpy.patch
> >
> > These patches are filed in enhanced_keymap_patches.tar.gz (attachment)
> > and need to be applied to master before building Hatari.
> >
> > A configuration file : keymap_fr_pc.cfg (found in attachment)
> > explains the format of the configuration file and gives an example
> > of Hatari key mapping for french PC keyboard layout (105 keys)
> >
> > Yves