Re: [hatari-devel] WinUAE CPU core disassembler output options : fix for DISASM_FLAG_EA

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 02/11/2022 à 22:14, Nicolas Pomarède a écrit :
> Le 25/10/2022 à 23:48, Eero Tamminen a écrit :
>
> > > before:
> > >
> > > 00fc054a 4e75                     rts  == $00fc03bc
> > >
> > > now :
> > >
> > > 00FC054A 4E75                     rts šZòºÌ^?
> > >
> > > Bcc od DBcc are correct, they still show "== EA" after.
> > >
> > > Can you have a look ? (maybe it's a regression in WinUae, I didn't 
> > > check)
> >
> > I think *both* of above behaviors are WinUAE disassembler bugs.
> >
> > First bug is disassembler not respecting its DISASM_FLAG_CC / 
> > DISASM_FLAG_EA / DISASM_FLAG_VAL options being off.
> >
> > Second bug is it showing garbage when it skips showing EA values for 
> > short enough instruction names.  E.g. not padding things properly 
> > (like Hatari ext disassembler does).
> >
> > Just enable "uae: show EA + CC values after instruction" disassembly 
> > option until Toni fixes those bugs.
>
> Hi
>
> toni, I think a test is missing for DISASM_FLAG_EA in i_Bcc and i_DBcc, 
> as the " == $%08X" is always displayed :

Hi

pushed the changes to WinUAE and they're now in Hatari, so disasm flags 
should work as expected now.

Nicolas