Re: [hatari-devel] macOS version check |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] macOS version check
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 1 Oct 2022 05:26:17 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1664601980; bh=YVpwtw79lwBVg2iDKDg6TOl5ev6Wv/uxwzsiwC17hXw=; h=Date:From:To:Subject:From; b=QAZ2UiUI/9I0xIKnEFa+HcOS0Dg+uldEuv3jL19O7jIv0skzZqUpX57g14SAOfSYf k6Ih25K1OO2R6Y/WIxh0yP8qntXlC/d+rRyfbGdaOJ+eW1ND0JFbdCiqBD8bnOmSeT bk2Ho6otuPyIZLxoxfGiO8F8Dxzhotl5d5475BE1jcrDst3prSuBehemShk4Wx6PW2 bp5KI6udZNe6l0N8DSrggaPoSIi/gcjvcaSxpoiylXldtuuwgc7xejCIXnNGOV78gb FS9sB4EFjCNF7e1qbYFb2JPvtwvenAzQoHpJBzRCYHJFaTszKUoszanZi83kzSbXvZ OE/NtBv6S284A==
Am Fri, 30 Sep 2022 18:19:18 +0100
schrieb Chris Jenkins <cdpjenkins@xxxxxxxxx>:
[...]
> It looks like the MacOS version is used to determine whether Hatari was
> launched from Finder (I guess as opposed to being launched from the command
> line) which only has a couple of minor effects:
> - Causes document open requests to be handled as though they were command
> line arguments
> - Causes the working directory to be set to the directory that contains
> Hatari.app - which would usually be /Applications
>
> The consequence of the bug is that if you launch Hatari from Finder on
> MacOS >= 11 then the above two things don't happen. (I confess I hadn't
> noticed it myself, perhaps because I most commonly launch Hatari from the
> command line these days).
>
> Attached is a patch that fixes the version detection logic. I can confirm
> that the working directory is now set as expected if I launch Hatari from
> Finder on my Mac (running MacOS 12.6).
Thanks to both of you, Thorsten for spotting it, and Chris for writing
the patch! I've committed it now!
Thomas