Re: [hatari-devel] Switching from SDL_types.h to inttypes.h ?

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Le 28/09/2022 à 16:01, Thomas Huth a écrit :
On 28/09/2022 14.58, Nicolas Pomarède wrote:
Le 24/09/2022 à 13:53, Thomas Huth a écrit :

Opinions? Would it be OK to switch non-SDL related files to uint16_t
instead of Uint16 etc. ? Or is anybody really keen on keeping the SDL types?

Hi

you changed types in several parts already, do you have a small sed script or similar to do it and do you plan to change the rest of the code ?

I basically did:

  for x in 8 16 32 ; do \
   sed -i "s/Uint${x}/uint${x}_t/g" file.c ; \
  done
  for x in 8 16 32 ; do \
   sed -i "s/Sint${x}/int${x}_t/g" file.c ; \
  done

Just wondering if I should change myself avi_record.c or mfp.c for example or just wait that you complete the rest of the changes ?

I've got no uncommitted work right now, so feel free to go ahead!
(otherwise, I'll continue that work sometime in the future when I find some spare minutes again. So far, I just wanted to clean the files that needed the types from main.h first, and that's what I achieved so far ... however, there are still some other issues left to make main.h independent from the SDL stuff, like the "#define strlcpy" in str.h, so it will take some more work to really be able to drop the SDL_types.h from main.h)

OK, I will have a look myself at some of the files.

BTW, I see you didn't replace size=64 in your sed, it's not used often but there're a few places that require it for global cycles counter.




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/