[hatari-devel] Re: Make building the Python GTK+3 user interface conditional. (PR #21)

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Hi,

On 30.7.2022 9.28, Thomas Huth wrote:
could you please have a look at the PR below, please?

I checked the patch.

Sounds basically ok to me, but wouldn't it be better to probe for the
python package instead of introducing a user-selectable switch in the CMake
file?

I completely agree.

There should be CMake test that checks whether this works instead:
------------
#!/usr/bin/python3
import gi
# use correct version of gtk
gi.require_version('Gtk', '3.0')
from gi.repository import Gtk
from gi.repository import Gdk
from gi.repository import GdkPixbuf
from gi.repository import GLib
------------
(code taken from dialogs.py)


	- Eero


  Thomas


Beginn der weitergeleiteten Nachricht:

Datum: Fri, 29 Jul 2022 09:19:46 -0700
Von: Frederic Cambus <notifications@xxxxxxxxxx>
An: hatari/hatari <hatari@xxxxxxxxxxxxxxxxxx>
Cc: Subscribed <subscribed@xxxxxxxxxxxxxxxxxx>
Betreff: [hatari/hatari] Make building the Python GTK+3 user interface
conditional. (PR #21)


This introduces an ENABLE_UI configuration option (enabled by default),
which allows disabling the user interface on systems where the Python
GTK+3 bindings are not available.
You can view, comment on, or merge this pull request online at:

   https://github.com/hatari/hatari/pull/21

-- Commit Summary --

   * Make building the Python GTK+3 user interface conditional.

-- File Changes --

     M CMakeLists.txt (20)

-- Patch Links --

https://github.com/hatari/hatari/pull/21.patch
https://github.com/hatari/hatari/pull/21.diff




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/