Re: [hatari-devel] Open Hatari in big window

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Wed, 1 Apr 2020 00:43:11 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:

> Hi,
> 
> On 3/31/20 10:49 PM, th.huth@xxxxxxxxx wrote:
> > Am 29.03.2020 01:54 schrieb Eero Tamminen:  
> >> On 3/28/20 9:17 PM, th.huth@xxxxxxxxx wrote:  
> >>> 1st patch: Did you check with sizeof(CNF_STRUCT) that this really 
> >>> makes a difference? Otherwise just drop the patch, please.  
> >>
> >> CNF_SOUND size isn't changed, it's 4112 with both, so I dropped
> >> that part of the patch.
> >>
> >> CNF_SCREEN size decreases, so I left that:
> >> - SDL2: 64 -> 56
> >> - SDL1: 56 -> 48  
> > 
> > Ok, fine for me, I think it should be OK to commit this.  
> 
> Pushed.
> 
> 
> >>> Please also do not separate pfmt from rm, gm and bm.  
> >>
> >> Format is needed to re-create the texture, but
> >> red, green & blue are needed only for surface
> >> creation.
> >>
> >> Are you saying that I should re-create also
> >> surface whenever scale factor is changed, although
> >> that is redundant?  
> > 
> > No. Could you just simply pass pfmt as parameter to 
> > Screen_SetTextureScale, please?  
> 
> main.c::Main_EventHandler() needs to call that on window resizes, and
> it doesn't know anything about format.

Ok, I missed that.

> Would separate function providing both masks & format for given
> bitdepth be any better?
> 
> (See attached patch.)

No, I in this case, you better keep your original solution.

I now also gave your patches a try (yes, I'm finally back at home!),
and I think it's ok to commit them. It's indeed a little bit confusing
that low resolutions are now scaled with "-z 1" by default, too, but I
also don't have a better idea with regards to the problem that you get
very different window sizes otherwise when the zoom factor is read from
the config file and you either start in mono or in color resolution
mode...

Maybe we should simply not save the zoom factor to the config file
instead? Or maybe we should offer the possibility to configure two
different zoom factors, one for low resolutions, and one for "normal"
resolutions?

Anyway, if we decide to go with the current approach, I think you
should improve this documention section from your 4th patch:

+With Hatari SDL2 build, ST-low resolution is always doubled, so that
+all resolutions have approximately same starting size. Any zoom factor
+can be used to scale that up (or down), regardless of the selected
+Atari machine or monitor type.

Please mention that it is possible to prevent the automatic doubling by
specifying smaller values with --max-width and --max-height.

 Thomas