Re: [hatari-devel] Small CMAKE diff

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Am Thu, 24 Jan 2019 12:42:11 +0100
schrieb Christer Solskogen <christer.solskogen@xxxxxxxxx>:

> Hi!
> 
> I'm experimenting with a multilib capable cross compiler (instead of
> having two, one for 32bit and one for 64bit) for Windows, but I'm not
> able to compile hatari without the following change:
> 
> diff -r bc68d35faa8b src/CMakeLists.txt
> --- a/src/CMakeLists.txt        Thu Jan 24 00:28:46 2019 +0200
> +++ b/src/CMakeLists.txt        Thu Jan 24 12:36:31 2019 +0100
> @@ -127,7 +127,7 @@
>                 set(CMAKE_RC_COMPILER windres)
>         endif(NOT CMAKE_RC_COMPILER)
>         ENABLE_LANGUAGE(RC)
> -       set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> -Ocoff -o
> <OBJECT> <SOURCE>")
> +       set(CMAKE_RC_COMPILE_OBJECT "<CMAKE_RC_COMPILER> <FLAGS>
> -Ocoff -o <OBJECT> <SOURCE>")
>         set_source_files_properties(${GUIWIN_RES} PROPERTIES LANGUAGE
> RC) add_executable(hatari ${GUIWIN_RES} ${SOURCES} ${GUIWIN_SOURCES})
> 
> 
> Could someone please commit it, please? It does not seem to cause any
> trouble for native builds. At least not for me.

 Hi!

Was there a concluse whether this is now OK or not? Nicolas, did you
try whether this still works for your MinGW cross builds or not?

 Thomas



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/