Re: [hatari-devel] fix a warning for debugui.c

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Sat, 10 Feb 2018 19:48:55 +0100
schrieb Thorsten Otto <admin@xxxxxxxxxxx>:

> On Samstag, 10. Februar 2018 19:32:00 CET Thomas Huth wrote:
> > Am Sat, 10 Feb 2018 00:05:32 +0200
> > 
> > schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:  
> > > Hi,
> > > 
> > > On 02/09/2018 01:16 PM, benoît tuduri wrote:  
> > > > LLVM report a warning with the Hatari string and the
> > > > rl_readline_name type conflict.
> > > > 
> > > > The fixes seems fix it. It's in a attachment  
> > > 
> > > Thanks for the patch, but it's not a fix.
> > > 
> > > The problem is your readline.h header.
> > > 
> > > Mine defines rl_readline_name as const pointer:
> > > $ grep rl_readline_name /usr/include/readline/*
> > > /usr/include/readline/readline.h:extern const char
> > > *rl_readline_name;  
> > 
> > The problem might be that macOS uses libedit instead of
> > libreadline, so I guess the problem is located in that lib. I think
> > you should report this problem to the libedit project so that they
> > fix it there.
> > 
> >  Thomas  
> 
> You could also do something like
> 
> static char my_rl_readline_name[] = "Hatari";
> rl_readline_name = my_rl_readline_name;
> 
> That should work regardless how the variable is declared.

You're right, that should do the trick! Committed. Thanks for the
suggestion!

 Thomas