| Re: [hatari-devel] fix a warning for debugui.c |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] fix a warning for debugui.c
- From: benoît tuduri <benoit.tuduri@xxxxxxxxx>
- Date: Sat, 10 Feb 2018 19:13:02 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=1X0CkwX9F+90IARC5e6EVFac8XsvlsW/iRsmC749Slg=; b=JsdHkj6dhzMesoXHFH1gnBjGB8dSE5matn+veRreGNwlhyRdLxNNqSVZOFqxDE8+1B 5DbFWWOLi5/FM6Tt0L2l6MIvt4hRO6juwoxyoUQQv3GKIityecm1R8dduKmHkJ9GZKdB YesgBeSeTZJm9TSuT5kxx6BhS350L2nYK1j/8xjC20aTBJxYVQqbo1JSoeTIqazF6J76 U0aI8bfa35ZzwPNYPKC59YBQfq6dj78yp0x7uBM4GqouAIdMk7t53Eq8OfV3U1dsPB38 0rtLmTWY6Eiiz1glFEiPLHOMLbGgrO23S4UWTwLg8DU5lhEMqwyNeUu0pQ1+Qsre9M+e D7zw==
Thanks Eero, for your answer.
Here I had the same :
homebrew/Cellar/readline//7.0.3_1/include/readline/readline.h:extern
const char *rl_readline_name;
but during the compilation LLVM :
[ 5%] Built target build68k
/Users/user/github/hatari-l/src/debug/debugui.c:813:19: warning: assigning to
'char *' from 'const char [7]' discards qualifiers
[-Wincompatible-pointer-types-discards-qualifiers]
rl_readline_name = "Hatari";
^ ~~~~~~~~
The compiler report this warning. So, I guess you had the same one ?
Regards,
2018-02-09 23:05 GMT+01:00 Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> On 02/09/2018 01:16 PM, benoît tuduri wrote:
>>
>> LLVM report a warning with the Hatari string and the rl_readline_name
>> type conflict.
>
>>
>>
>> The fixes seems fix it. It's in a attachment
>
>
> Thanks for the patch, but it's not a fix.
>
> The problem is your readline.h header.
>
> Mine defines rl_readline_name as const pointer:
> $ grep rl_readline_name /usr/include/readline/*
> /usr/include/readline/readline.h:extern const char *rl_readline_name;
>
>
> - Eero
>
>