Re: [hatari-devel] Keyboard shortcut definition dialog

[Thomas Huth <th.huth@xxxxxx>]

Am Sun, 27 Dec 2015 18:12:08 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:

> Hi,
> 
> Thomas, I noticed that you added SDL GUI support for
> defining keyboard shortcuts.  I don't think the current
> logic works yet as it should.
> 
> If you browse through the shortcuts, you see that there's
> no shortcut key shown for "Pause".  This is because the code
> assumes that initially all shortcuts are with modifier, and
> it unconditionally sets that checkbox.
> 
> Instead, it should check whether that shortcut is defined
> with modifier or not, and only then set the checkbox, when
> user changes the shortcut.
> 
> Then, only if user changes the modifier setting, that should
> be changed from the configuration.   Mostly untested fix
> patch for these is attached.

That's not how shortcuts currently work in Hatari. Hatari supports two
independents sets of shortcuts, one with modifier, one without. So you
can define two independent ways to trigger one shortcut action. This is
already the default for the shortcut that opens the settings dialog,
for example: You can either press F12 _or_ AltGr+o to get there.

So unless we want to change that behavior completely, I think the
current way is ok to configure these two independend sets of shortcuts.

 Thomas