Re: [hatari-devel] DSP addressing bug

On 23 October 2015 at 12:52, <laurent.sallafranque@xxxxxxx> wrote:

Hi Doug,

> Quick question Laurent - does the patch also work for (Rn)-Nn addressing?

It should ;)

But I think I understand precisely the problem now (in hatari, -Nn is passed as a negative argument to the function when the addressing mode is (Rn)-Nn, I'll have to rewrite it by adding a sign variable and keeping Nn unchanged).
Don't expec this fix before tuesday or wednesday (we'll have family at home in the next days).

At least, I see how to fix it definitively now.

Regards

Laurent

----- Mail original -----
De: "Douglas Little" <doug694@xxxxxxxxxxxxxx>
À: hatari-devel@xxxxxxxxxxxxxxxxxxx
Envoyé: Vendredi 23 Octobre 2015 12:20:16
Objet: Re: [hatari-devel] DSP addressing bug

Quick question Laurent - does the patch also work for (Rn)-Nn addressing?

If I keep my workaround just for this case and remove it for the (Rn)+Nn cases the remaining problem seems to go away...

D

On 23 October 2015 at 11:11, Douglas Little < doug694@xxxxxxxxxxxxxx > wrote:

Yep definitely something is slightly different on real HW. I'm getting selectively black pixels in Hatari where they look correct on HW. Previously I was getting a completely destroyed image.

It's going to take effort to figure out what's going on but I still see some kind of problem. I'll try to narrow it down a bit.

D.

On 23 October 2015 at 10:54, Douglas Little < doug694@xxxxxxxxxxxxxx > wrote:

Perhaps I spoke too soon. There is something funny still happening - but I'll need to do more checks to make sure it's not my fault. I'll update soon when i have more info....

Doug.

On 23 October 2015 at 10:13, Douglas Little < doug694@xxxxxxxxxxxxxx > wrote:

It works for me - everything looks good!

Thanks :)

I'll report if I run into any problems with it but I don't think so..

D.

On 22 October 2015 at 22:10, Laurent Sallafranque < laurent.sallafranque@xxxxxxx > wrote:

I've already tested :

EKO_systems : still working to the end
TERE RA'I ;) : still working to the end
Sololuminezcent : still working to the end

underscore demo seems to crash now but it also crash with the n-1 version of hatari (ie without my patch).
There's a regression with this demo, it was at least working to the 4rth screen before.

I continue some tests but the patch seems OK to me.

Regards

Laurent

Le 22/10/2015 23:02, Nicolas Pomarède a écrit :

Le 22/10/2015 22:57, Douglas Little a écrit :

Woo, that was quick. Thanks!

If the patch has made it into the repo, I can just collect tomorrow's
nightly build and see if that works for me. Sounds like it probably
will. Otherwise I'll try a local build tomorrow.

Hi,

unfortunately, it seems builds at http://antarctica.no/~hatari/ are not regularly updated anymore (and it even returns a HTTP 503 error at the moment :( )

Nicolas