Re: [hatari-devel] beautify sdl-gui underlines patch

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On tiistai 03 helmikuu 2015, David Savinkoff wrote:
> The sdl-gui looks good. Thanks. Enclosed is a picture
> to compare with the previous I sent.

Ok, I commited that version.

I think the character bg color would've been a bit too distracting. :-)


	- Eero
> 
> Sincerely,
> David Savinkoff
> 
> ----- Eero Tamminen wrote:
> > Hi,
> > 
> > I think this needs opinions from others.
> > 
> > On maanantai 02 helmikuu 2015, David Savinkoff wrote:
> > > Good thing you said no, because this one is better.
> > 
> > First you were saying that you want shortcut indicator to be less
> > visible, but your new patch makes it much more visible?
> > 
> > 
> > I saw from your screenshots what I think you had an issue with,
> > underlines going over the text on next line.  What about attached
> > patch?
> > 
> > With it the underline in non-zoomed mode doesn't go over next line text
> > (like currently), it doesn't go over button border (like in your
> > previous patch).  And it uses more visible color (in non-zoomed mode)
> > because otherwise underline could be mistook for a badly rendered
> > font.
> > 
> > 	- Eero