Re: [hatari-devel] Re: Interesting sound problems with Hatari?

Hi,

I need clarification on what works.
Is fifo-mic.1.patch satisfactory?
What needs improvement?

Unfortunately I am unable to test that patch in any meaningful way - I am only working with specific circumstances for audio replay on Falcon, which is critical to completing my own project.

----- Douglas Little wrote:
> I think the changes I proposed shouldn't be considered final - there is

what changes in particular?

The changes discussed earlier in this thread, relating to the storing of zeroes to the Codec ringbuffer read head. Zeroes are pushed on the first access to the current read position, but the read position is not assured to move forward by one whole unit (fixedpoint increment). So the next fetch can become corrupted with unexpected zeroes.

> probably a more correct way to fix it. However, I had a bad experience this
> evening which suggests something really should be done soon - either apply
> the temporary fix with intent to figure out a better solution, or fix it

which fix is this?

As referenced above - the zeroes are stored to the read head only if the ringbuffer read head actually advances for that sample.

I offered opinions that storing to the read head at all might not be a good idea - and LaurentS also suggested that the read head could move forward by more than one unit, dependent on replay frequency etc. Which I also agree with. So I believe a more conclusive fix is waiting to be developed. I'm just not in a good position to figure out the right way, partly due to time and partly because I don't have a good enough understanding of the purpose of these writes, except that they fix some other problem.

> Of course only at this point I realized I had been running the 'wrong'
> version of Hatari out of habit (the downloaded version via shortcut,
> instead of my local build which includes the patch, launched via CygwinX)

which patch?

I didn't actually submit a diff/patch file - I just highlighted the code in the message, and which corrections i made. It can be found a few messages back, under the same topic header.

If a literal patch file is needed I can supply one, but the change is trivial - moved a couple of lines, added an if statement .